Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use metrics.ClientConfig.Prefix as otel namespace #7312

Closed
wants to merge 1 commit into from

Conversation

cludden
Copy link
Member

@cludden cludden commented Feb 10, 2025

What changed?

Propagates go.temporal.io/sdk/common/metrics.ClientConfig.Prefix to opentelemetry exporter options in NewOpenTelemetryProvider

Why?

Previously, this was handled by NewScope, which is no longer invoked as of #7265

How did you test it?

Potential risks

Documentation

Is hotfix candidate?

@yycptt
Copy link
Member

yycptt commented Feb 11, 2025

Dup of #7297

@yycptt
Copy link
Member

yycptt commented Feb 11, 2025

I've also reverted #7265

@yycptt yycptt closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants