Skip to content

Commit

Permalink
Move workflow run loading store to it's own file so it can be imported (
Browse files Browse the repository at this point in the history
  • Loading branch information
Alex-Tideman authored Dec 9, 2022
1 parent bc21f1e commit f0ef6d1
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 4 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@temporalio/ui",
"version": "2.1.92",
"version": "2.1.93",
"type": "module",
"description": "Temporal.io UI",
"keywords": [
Expand Down
3 changes: 2 additions & 1 deletion src/lib/layouts/workflow-run-layout.svelte
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<script lang="ts">
import { page } from '$app/stores';
import { workflowRun, loading } from '$lib/stores/workflow-run';
import { workflowRun } from '$lib/stores/workflow-run';
import { loading } from '$lib/stores/workflow-run-loading';
import { timelineEvents } from '$lib/stores/events';
import Header from '$lib/layouts/workflow-header.svelte';
Expand Down
3 changes: 3 additions & 0 deletions src/lib/stores/workflow-run-loading.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { writable } from 'svelte/store';

export const loading = writable(true);
2 changes: 1 addition & 1 deletion src/lib/stores/workflow-run.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import type { GetPollersResponse } from '$lib/services/pollers-service';
import { decodeURIForSvelte } from '$lib/utilities/encode-uri';
import { toDecodedPendingActivities } from '$lib/models/pending-activities';
import { authUser } from '$lib/stores/auth-user';
import { loading } from '$lib/stores/workflow-run-loading';

export const refresh = writable(0);
const namespace = derived([page], ([$page]) => $page.params.namespace);
Expand Down Expand Up @@ -73,7 +74,6 @@ const updateWorkflowRun: StartStopNotifier<{
};

export const updating = writable(true);
export const loading = writable(true);
export const workflowRun = readable<WorkflowRunStore>(
initialWorkflowRun,
updateWorkflowRun,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script lang="ts">
import { onDestroy } from 'svelte';
import { loading } from '$lib/stores/workflow-run';
import { loading } from '$lib/stores/workflow-run-loading';
import { clearPreviousEventParameters } from '$lib/stores/previous-events';
onDestroy(() => {
Expand Down

2 comments on commit f0ef6d1

@vercel
Copy link

@vercel vercel bot commented on f0ef6d1 Dec 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

ui – ./

ui-lyart.vercel.app
ui-git-main.preview.thundergun.io
ui.preview.thundergun.io

@vercel
Copy link

@vercel vercel bot commented on f0ef6d1 Dec 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

holocene – ./

holocene-git-main.preview.thundergun.io
holocene.preview.thundergun.io

Please sign in to comment.