Refactor out payload inputs to its own component and add encoding field #2370
+189
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld to set encoding
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Alex-Tideman
requested review from
stevekinney,
rossedfort and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Allow users to set the encoding field of a payload for Signal, Schedule Input and Start Workflow Input to either:
Also update decode logic to base64 decode all payloads since all payloads will be returned base64 encoded regardless of codec server or not.
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
if (encoding?.startsWith('json/')) {... in decode-payload?Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?