International surname prefix fixes #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be a currently accepted way to write Arabic surnames. Source: >"Al-" and its variants (ash-, ad-, ar-, etc.) are always written in lower case (unless beginning a sentence), and a hyphen separates it from the following word. > > https://en.wikipedia.org/wiki/Wikipedia:Manual_of_Style/Arabic#Definite_article
According to New Hart's Style, > The _ben_ that occurs in many Hebrew names > means 'son of'; this is the traditional > Jewish way of naming Jewish males. The > female form is _bat_ 'daughter of'. In pre- > modern times a man would usually be known > simply as the son of his father: > _Avraham ben David_ (Avraham the son of David). > ... > Then _Ben_ that often fiures in modern Israeli > names represents a different usage: now part > of the surname, it should be hyphenated to it > and capitalized, as in _David Ben-Gurion_, and > alphabetized under _B_.
This also required specifying that roman numerals ought to appear before a space or at the end of the string, otherwise, "l'" was being upcased by the roman numeral substitution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #12 and steals the changes from #10 also.