Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting #19

Merged
merged 9 commits into from
Dec 5, 2024
Merged

Linting #19

merged 9 commits into from
Dec 5, 2024

Conversation

Jakob-Unfried
Copy link
Member

No description provided.

@Jakob-Unfried Jakob-Unfried self-assigned this Nov 26, 2024
@Jakob-Unfried Jakob-Unfried force-pushed the linting branch 2 times, most recently from f684a57 to 074694b Compare November 27, 2024 11:38
@Jakob-Unfried
Copy link
Member Author

Jakob-Unfried commented Dec 5, 2024

  •  Prep hooks
  • Documentation / readme (include hooks)

@Jakob-Unfried Jakob-Unfried force-pushed the linting branch 2 times, most recently from e42ebfc to 02112d2 Compare December 5, 2024 14:40
@Jakob-Unfried
Copy link
Member Author

I pasted a minimal version of the git hooks into the docs.
I do not want to have my convenience checks for FIXME strings and breakpoints in the repo, because
then they will trigger on their own copy...

If you want to use my full scripts, find them pasted in #14

@Jakob-Unfried Jakob-Unfried merged commit 8d544c4 into main Dec 5, 2024
3 of 5 checks passed
@Jakob-Unfried Jakob-Unfried deleted the linting branch December 5, 2024 16:02
@jhauschild
Copy link
Member

jhauschild commented Dec 10, 2024

@Jakob-Unfried what's the ggrep command that you have in the example pre-commit?

@Jakob-Unfried
Copy link
Member Author

Jakob-Unfried commented Dec 10, 2024

@Jakob-Unfried what's the ggrep command that you have in the example pre-commit?

Ah right. This is a mac os specific thing.
It is plain old GNU grep, the brew installer creates an alias as ggrep so it doesnt shadow the mac os builtin grep.

On Linux, just remove the extra g and use grep.

I will adjust it accordingly.

@Jakob-Unfried
Copy link
Member Author

@jhauschild fixed in both the repo docs and in #14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants