Update DTensor docs, lint notebooks #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PreviewPreview and run these notebook edits with Google Colab:
Format and styleUse the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:$ python3 -m pip install -U --user git+https://github.com/tensorflow/docsIf commits are added to the pull request, synchronize your local branch: git pull origin update-dtensor
|
8bitmp3
commented
Sep 29, 2023
| @@ -98,7 +100,7 @@ | |||
| }, | |||
| "outputs": [], | |||
| "source": [ | |||
| "!pip install --quiet --upgrade --pre tensorflow" | |||
There was a problem hiding this comment.
@MarkDaoust removed the "--pre"
8bitmp3
commented
Sep 29, 2023
| @@ -76,7 +76,7 @@ | |||
| "\n", | |||
| "By decoupling the application from sharding directives, DTensor enables running the same application on a single device, multiple devices, or even multiple clients, while preserving its global semantics.\n", | |||
| "\n", | |||
| "This guide introduces DTensor concepts for distributed computing, and how DTensor integrates with TensorFlow. To see a demo of using DTensor in model training, see [Distributed training with DTensor](https://www.tensorflow.org/tutorials/distribute/dtensor_ml_tutorial) tutorial." | |||
There was a problem hiding this comment.
@MarkDaoust introduced a relative link
8bitmp3
commented
Sep 29, 2023
| @@ -107,9 +109,9 @@ | |||
| "id": "O3pG29uZIWYO" | |||
| }, | |||
| "source": [ | |||
| "Once installed, import `tensorflow` and `tf.experimental.dtensor`. Then configure TensorFlow to use 6 virtual CPUs.\n", | |||
There was a problem hiding this comment.
@MarkDaoust full API with tf.experimental is mentioned in the beginning of the section, so shortened this.
Later, "vCPU" -> "virtual CPU"
MarkDaoust
previously approved these changes
Sep 29, 2023
site/en/guide/dtensor_overview.ipynb
Outdated
| @@ -98,7 +100,7 @@ | |||
| }, | |||
| "outputs": [], | |||
| "source": [ | |||
| "!pip install --quiet --upgrade --pre tensorflow" | |||
| "!pip install --quiet --upgrade tensorflow" | |||
There was a problem hiding this comment.
We usually don't bother with installing tensorflow. It was only here because the pre-installed version was insufficient.
| @@ -99,7 +102,7 @@ | |||
| }, | |||
| "outputs": [], | |||
| "source": [ | |||
| "!pip install --quiet --upgrade --pre tensorflow tensorflow-datasets" | |||
| "!pip install --quiet --upgrade tensorflow tensorflow-datasets" | |||
There was a problem hiding this comment.
Will remove this, and lint the notebooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.