Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created using Colaboratory #846

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Bobbyorr007
Copy link

I had a few changes in the markdown edited; just a few typo errors.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-cla
Copy link

google-cla bot commented Mar 12, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@Bobbyorr007
Copy link
Author

Bobbyorr007 commented Mar 12, 2022

I had some typo errors corrected in the markdown.

Copy link
Collaborator

@WGierke WGierke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the typos!
It looks like the tool you used also stored some additional metadata that's not necessary to store. Could you revert these sections? It might be even easier to just take a fresh copy of the colab and fix the typos using an editor or command-line tool. Thank you!

@@ -1,5 +1,15 @@
{
"cells": [
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove that section again, please?

@@ -606,13 +615,15 @@
"name": "Object Detection Inference on TF 2 and TF Hub",
"private_outputs": true,
"provenance": [],
"toc_visible": true
"toc_visible": true,
"include_colab_link": true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove these additions

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll, and created a pull request, thank you!

@Bobbyorr007
Copy link
Author

I have tried removing those parts; I think it is linked to the open with colab linkage.

@WGierke
Copy link
Collaborator

WGierke commented Mar 24, 2022

It seems like the PR would currently try to add two new Colabs. Could you remove them and only modify the tf2_object_detection Colab by fixing the typos?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants