Fix: failures during experimental feature parallel compile #8510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #6250, which highlights the need for clear execution separation between Tensors and SymbolicTensors.
It improves the
apply()
function in TensorFlow.js by explicitly handling synchronous (Tensor-based) and asynchronous (SymbolicTensor-based) execution separately.1. Clear separation of sync and async execution:
1.1 If inputs are Tensors, execution happens synchronously.
1.2 If inputs are SymbolicTensors, execution happens asynchronously.
2. Ensured backward compatibility:
2.1 No change in how inputs are processed.
2.2 Layer building, weight loading, and input validation remain intact.
Currently, the
apply()
function mixes both execution types in a single flow, making it harder to debug and optimize. This PR makes it explicit when the function runs in sync or async mode, helping both performance and readability.Fixes #6250