Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: failures during experimental feature parallel compile #8510

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ac-mmi
Copy link

@ac-mmi ac-mmi commented Feb 6, 2025

This PR addresses issue #6250, which highlights the need for clear execution separation between Tensors and SymbolicTensors.
It improves the apply() function in TensorFlow.js by explicitly handling synchronous (Tensor-based) and asynchronous (SymbolicTensor-based) execution separately.

1. Clear separation of sync and async execution:
1.1 If inputs are Tensors, execution happens synchronously.
1.2 If inputs are SymbolicTensors, execution happens asynchronously.

2. Ensured backward compatibility:
2.1 No change in how inputs are processed.
2.2 Layer building, weight loading, and input validation remain intact.

Currently, the apply() function mixes both execution types in a single flow, making it harder to debug and optimize. This PR makes it explicit when the function runs in sync or async mode, helping both performance and readability.

Fixes #6250

Copy link

google-cla bot commented Feb 6, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failures during experimental feature parallel compile
1 participant