Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect getting started link in README.md in examples directory #269

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pritamdodeja
Copy link

@zoyahav
Copy link
Member

zoyahav commented May 23, 2022

Thanks for the PR. Why point to the TFX site rather than https://github.com/tensorflow/transform/blob/master/docs/get_started.ipynb?
The latter will be more in sync with the github repo.

Updated link in examples/README.md to point to local notebook in repo,
specifically to https://github.com/tensorflow/transform/blob/master/docs/get_started.ipynb
@pritamdodeja
Copy link
Author

Thanks for the PR. Why point to the TFX site rather than https://github.com/tensorflow/transform/blob/master/docs/get_started.ipynb? The latter will be more in sync with the github repo.

Makes sense. I have updated the branch referenced in the PR to the link that you mentioned. Thank you!

@pritamdodeja
Copy link
Author

@zoyahav what do you think about featuring the getting started notebook more prominently off of https://github.com/tensorflow/transform/blob/master/README.md itself, and making it a relative reference so that anybody that clones the repo can try it out locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants