Fix U.export_to("path.png)" syntax
#358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has annoyed quite some people for so long -- thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code does not seem to allow writing
U.export_to("path.png")for me, even though it claims to, so I might be missing something.But I believe the reason for this is that named arguments are processed after unnamed arguments, so even when adding a named argument for circuit, the filename still gets interpreted as a circuit argument.
A simple solution is to explicitly pass self as the first unnamed argument. Since this is a convenience function on the circuit, I can't think of a case where you'd want to pass something other than self.