Reaction tangent controller #138

AbdAlazezAhmed · 2024-08-14T19:44:19Z

No description provided.

and one more test and commented tests because we need a way to find which operator in the split is B

termi-official

Thanks, this already looks great! I found some things which we should address before merge.

src/solver/adaptivity.jl

src/solver/operator_splitting/solver.jl

examples/conduction-velocity-benchmark.jl

src/solver/operator_splitting/integrator.jl

test/test_integrators.jl

and retcode oopsie

… into RTC

termi-official

Thanks! Almost there I think.

docs/src/assets/references.bib

docs/src/api-reference/solver.md

src/solver/adaptivity.jl

src/solver/operator_splitting/integrator.jl

test/test_integrators.jl

test/integration/test_electrophysiology.jl

…into RTC

docs/src/assets/references.bib

src/solver/adaptivity.jl

src/solver/operator_splitting/solver.jl

termi-official

Okay found a few more things to address when taking another look. Almost there tho.

src/Thunderbolt.jl

src/solver/adaptivity.jl

termi-official

Great work, thanks!

AbdAlazezAhmed added 10 commits August 13, 2024 19:56

init

b6aaeec

now it stops

83d4b6b

.

93d1eba

quick quick

ec3bd11

restructuring

85bc9ba

test?

a5ccab2

error and a couple of returns

0bf9c9e

some docs

aaf7eec

ugh zero default

03827ed

and one more test and commented tests because we need a way to find which operator in the split is B

.

6451030

termi-official requested changes Aug 14, 2024

View reviewed changes

AbdAlazezAhmed added 9 commits August 15, 2024 11:56

Now it doesn't allocate

7a39637

some formatting

5d78f91

example formatting

f909309

retcode

ca0cd7c

add \pi so it doesn't align with tstops hehe

e5dbc21

and retcode oopsie

nans but commented out

d2af0f9

assume only one problem

071ecd4

docs oopsie

921ab74

adaptive test UwU

c98c348

AbdAlazezAhmed marked this pull request as ready for review August 16, 2024 09:24

Merge branch 'main' of https://github.com/AbdAlazezAhmed/Thunderbolt.jl…

bad3da1

… into RTC

termi-official requested changes Aug 16, 2024

View reviewed changes

AbdAlazezAhmed added 7 commits August 19, 2024 15:43

Better?

b5b4195

Docs

0ccbd02

oopsie

b505899

Merge branch 'main' into RTC

6ef8ba3

Next: Error checking for NaNs

f3ad8d3

Merge branch 'RTC' of https://github.com/AbdAlazezAhmed/Thunderbolt.jl …

f1a72de

…into RTC

Try mabe CI works now?

c685bf3

termi-official requested changes Aug 21, 2024

View reviewed changes

AbdAlazezAhmed and others added 8 commits August 21, 2024 16:16

Don't merge, homeoffice push

06a541b

nans test

ffe2128

multiple pwodef

61ecbc9

Inf

fbeed40

indentation

e39a773

access u from caches directly

e19fd50

Merge branch 'main' into RTC

c981cf7

Merge branch 'main' into RTC

09b7993

termi-official approved these changes Aug 28, 2024

View reviewed changes

termi-official requested changes Aug 28, 2024

View reviewed changes

AbdAlazezAhmed added 7 commits August 30, 2024 12:13

remove unroll filter

68bd74c

adaptivity -> time/rtc

b7f6773

remove unused type

934a4d3

yes

0843020

or not to do

c912e1a

use only current R

3a64dcc

inf

5023e38

termi-official approved these changes Aug 30, 2024

View reviewed changes

termi-official merged commit 664d6cd into termi-official:main Aug 30, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reaction tangent controller #138

Reaction tangent controller #138

AbdAlazezAhmed commented Aug 14, 2024

termi-official left a comment

termi-official left a comment

termi-official left a comment

termi-official left a comment

Reaction tangent controller #138

Reaction tangent controller #138

Conversation

AbdAlazezAhmed commented Aug 14, 2024

termi-official left a comment

Choose a reason for hiding this comment

termi-official left a comment

Choose a reason for hiding this comment

termi-official left a comment

Choose a reason for hiding this comment

termi-official left a comment

Choose a reason for hiding this comment