Added default executor modifiable for tests. #15
Conversation
The executor abstraction allows us to introduce a mock executor, which removes the need for VBoxManage installed on the box, as well as introducting various failure scenarios which could then be tested and improve the reliability of the project. With the current implementation, the mock executor always returns nil, and allows all tests to pass. This behaviour should be changed in the future, perhaps adapted even more with closures to allow the list of items that should be returned as output.
VoyTechnology
force-pushed
the
mock-executor
branch
from
8db4d2f to
f8abf83
Compare
|
Related to #14. Not sure does it actually resolve the problem. |
|
@VoyTechnology last week, I have been digging into the graph of forks for this repository and found a fork which had a full mock including tests already available. I won't have time today to look it up again, but I can let you know by tomorrow. If you would have time already, have a look into the list of forks (https://github.com/terra-farm/go-virtualbox/network). |
|
I am not 100% sure, but I think https://github.com/asnowfix/go-virtualbox has the most complete fork. @asnowfix How do you feel about merging your changes upstream? |
|
No objection to propose my changes upstream... provided one can tell which repo is considered the active upstream one! |
|
This was the original repo, forked by many, and then donated to terra-farm. To my best knowledge this is the original repo. The issue to track pulling in changes is #7. If the changes are merged I would close this PR |
|
@VoyTechnology see #17 for the merge of the changes of @asnowfix into this repository. OK if we close this PR? |
|
@VoyTechnology I have merged the mock setup from @asnowfix from #17. Closing this PR. |
The executor abstraction allows us to introduce a mock executor, which removes
the need for VBoxManage installed on the box, as well as introducting various
failure scenarios which could then be tested and improve the reliability of the
project.
With the current implementation, the mock executor always returns nil, and
allows all tests to pass. This behaviour should be changed in the future,
perhaps adapted even more with closures to allow the list of items that should
be returned as output.
In its current state, the function signature should remain the same.