Nat Network Support #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 23, 2021
Closed
VoyTechnology
requested changes
Jun 28, 2021
| @@ -18,6 +19,8 @@ const ( | |||
| NICNetDisconnected = NICNetwork("null") | |||
| // NICNetNAT when the NIC is NAT-ed to access the external network. | |||
| NICNetNAT = NICNetwork("nat") | |||
| // NICNetNATNetwork when the NIC is on an internal network, with NATed external access. | |||
There was a problem hiding this comment.
This looks like a potential go fmt error. I have merged a change to update the linting on the CI. I think if you rebase this PR it should show up.
| return nil | ||
| } | ||
|
|
||
| func (n *NATNet) Config() error { |
There was a problem hiding this comment.
Config sounds like a function which will return some configuration. I think making it a verb Configure would portray the effect of this function better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the functionality in #13 and #11, rebased onto master and updated to use the
Mange().runfunctions.I am using this functionality successfully with a patched version of the terraform provider, and a couple of other minor patches to this library (to be introduced in different PRs).