Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add comment warning about expensive provisioned throughput mode #29

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

kodakmoment
Copy link
Contributor

Description

Add warning about cost of using provisioned throughput mode .

Motivation and Context

Give a fair warning for users blindly copying and testing with the firs example.

Breaking Changes

No

How Has This Been Tested?

No testing needed because only cosmetic comment.

  • [x ] I have executed pre-commit run -a on my pull request

@kodakmoment
Copy link
Contributor Author

This solves #28

examples/complete/main.tf Outdated Show resolved Hide resolved
examples/complete/main.tf Outdated Show resolved Hide resolved
examples/complete/main.tf Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@antonbabenko antonbabenko changed the title Add comment warning about provisioned troughput mode fix: Add comment warning about expensive provisioned throughput mode Mar 18, 2024
@antonbabenko antonbabenko merged commit f86d365 into terraform-aws-modules:master Mar 18, 2024
6 of 7 checks passed
antonbabenko pushed a commit that referenced this pull request Mar 18, 2024
## [1.6.2](v1.6.1...v1.6.2) (2024-03-18)

### Bug Fixes

* Add comment warning about expensive provisioned throughput mode ([#29](#29)) ([f86d365](f86d365))
@antonbabenko
Copy link
Member

This PR is included in version 1.6.2 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants