Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TPG>=5.43)!: replacing "no_age" -> "send_age_if_zero" #340

Merged

Conversation

jjnunogarcia
Copy link
Contributor

The documentation warns about the removal of this no_age param with the new send_age_if_zero. However, the code is not reflecting that.

The documentation warns about the removal of this "no_age" param. However, the code is not reflecting that.
@jjnunogarcia jjnunogarcia requested a review from a team as a code owner September 6, 2024 12:56
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jjnunogarcia!

Can you please bump the minimum provider to v5.43.0 as that is required for this change: https://github.com/terraform-google-modules/terraform-google-cloud-storage/blob/master/modules/simple_bucket/versions.tf#L23

@apeabody
Copy link
Contributor

apeabody commented Oct 1, 2024

/gcbrun

@jjnunogarcia
Copy link
Contributor Author

Thanks for the contribution @jjnunogarcia!

Can you please bump the minimum provider to v5.43.0 as that is required for this change: https://github.com/terraform-google-modules/terraform-google-cloud-storage/blob/master/modules/simple_bucket/versions.tf#L23

@apeabody Done :)

@apeabody apeabody changed the title fix: replacing "no_age" -> "send_age_if_zero" fix(TPG>=5.43)!: replacing "no_age" -> "send_age_if_zero" Oct 2, 2024
@apeabody
Copy link
Contributor

apeabody commented Oct 2, 2024

Thanks for the contribution @jjnunogarcia!
Can you please bump the minimum provider to v5.43.0 as that is required for this change: https://github.com/terraform-google-modules/terraform-google-cloud-storage/blob/master/modules/simple_bucket/versions.tf#L23

@apeabody Done :)

Thanks @jjnunogarcia! As you are adding the send_age_if_zero argument to the root module, that also needs to be bumped: https://github.com/terraform-google-modules/terraform-google-cloud-storage/blob/master/versions.tf

@jjnunogarcia
Copy link
Contributor Author

Thanks for the contribution @jjnunogarcia!
Can you please bump the minimum provider to v5.43.0 as that is required for this change: https://github.com/terraform-google-modules/terraform-google-cloud-storage/blob/master/modules/simple_bucket/versions.tf#L23

@apeabody Done :)

Thanks @jjnunogarcia! As you are adding the send_age_if_zero argument to the root module, that also needs to be bumped: https://github.com/terraform-google-modules/terraform-google-cloud-storage/blob/master/versions.tf

Oh gosh, I missed that @apeabody
It's fixed now, thanks!

@apeabody
Copy link
Contributor

apeabody commented Oct 2, 2024

/gcbrun

@apeabody apeabody merged commit f40bf31 into terraform-google-modules:master Oct 2, 2024
4 checks passed
@jjnunogarcia jjnunogarcia deleted the replacing-no-age-param branch October 3, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants