Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: migrate to ARC #173

Merged
merged 20 commits into from
Aug 7, 2024
Merged

feat!: migrate to ARC #173

merged 20 commits into from
Aug 7, 2024

Conversation

gtsorbo
Copy link
Collaborator

@gtsorbo gtsorbo commented Jul 23, 2024

No description provided.

@gtsorbo gtsorbo requested a review from a team as a code owner July 23, 2024 19:58
@gtsorbo gtsorbo marked this pull request as draft July 23, 2024 19:58
@gtsorbo
Copy link
Collaborator Author

gtsorbo commented Jul 23, 2024

/gcbrun

1 similar comment
@gtsorbo
Copy link
Collaborator Author

gtsorbo commented Jul 23, 2024

/gcbrun

@gtsorbo gtsorbo marked this pull request as ready for review July 26, 2024 18:53
@bharathkkb bharathkkb self-assigned this Jul 29, 2024
bharathkkb
bharathkkb reviewed Jul 29, 2024
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gtsorbo! Some initial comments

modules/gh-runner-gke/main.tf Outdated Show resolved Hide resolved
modules/gh-runner-gke/main.tf Show resolved Hide resolved
examples/gh-runner-gke-dind-rootless/main.tf Outdated Show resolved Hide resolved
modules/gh-runner-gke/variables.tf Outdated Show resolved Hide resolved
@bharathkkb bharathkkb changed the title feat: migrate to ARC feat!: migrate to ARC Aug 2, 2024
bharathkkb
bharathkkb approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also add an upgrade guide? I think an in place upgrade may be feasible but if not we can just explicitly state it is not possible and to spin up a new instance and turn down the old one.

test/integration/gh-runner-gke/gh_runner_gke_test.go Show resolved Hide resolved
@gtsorbo gtsorbo merged commit 0b1299b into master Aug 7, 2024
6 checks passed
@gtsorbo gtsorbo deleted the feat/arc-runners branch August 7, 2024 19:56
@release-please release-please bot mentioned this pull request Aug 7, 2024
Merged
@gtsorbo gtsorbo mentioned this pull request Aug 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

Assignees

@bharathkkb bharathkkb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtsorbo @bharathkkb