Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: existing scc instance for DA #106

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feat: existing scc instance for DA #106

wants to merge 19 commits into from

Conversation

jor2
Copy link
Member

@jor2 jor2 commented Aug 7, 2024

Description

Enable skipping SCC provisioning
terraform-ibm-modules/stack-retrieval-augmented-generation#131

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

enable skipping SCC provisioning by providing option for passing existing scc instance id.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this Aug 7, 2024
@jor2
Copy link
Member Author

jor2 commented Aug 7, 2024

Do we need to add an existing scc instance to permanent resources and specify it here?

@ocofaigh
Copy link
Member

ocofaigh commented Aug 12, 2024

@jor2 no we don't need a permanent SCC instance. One can be provisioned in https://github.com/terraform-ibm-modules/stack-ibm-core-security-services/tree/main/tests/resources as part of the test if needed

@jor2
Copy link
Member Author

jor2 commented Aug 14, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Aug 19, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Sep 2, 2024

/run pipeline

Jordan-Williams2 added 2 commits September 2, 2024 15:19
@jor2
Copy link
Member Author

jor2 commented Sep 2, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Sep 2, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Sep 2, 2024

/run pipeline

1 similar comment
@jor2
Copy link
Member Author

jor2 commented Sep 2, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Sep 3, 2024

failure related to this again it seems, retrying

@jor2
Copy link
Member Author

jor2 commented Sep 4, 2024

/run pipeline

@ocofaigh
Copy link
Member

ocofaigh commented Sep 4, 2024

@jor2 hoping to do a release this week for core security services stack DA. Do we keep hitting the same issue in the tests here?

@jor2
Copy link
Member Author

jor2 commented Sep 4, 2024

@jor2 hoping to do a release this week for core security services stack DA. Do we keep hitting the same issue in the tests here?

yes, same issue we thought solved before.

 2024/09/04 10:37:45 Terraform apply | Error: CreateTopicWithContext failed Incorrect source id
 2024/09/04 10:37:45 Terraform apply | {
 2024/09/04 10:37:45 Terraform apply |     "StatusCode": 400,
 2024/09/04 10:37:45 Terraform apply |     "Headers": {
 2024/09/04 10:37:45 Terraform apply |         "Access-Control-Allow-Credentials": [
 2024/09/04 10:37:45 Terraform apply |             "true"
 2024/09/04 10:37:45 Terraform apply |         ],
 2024/09/04 10:37:45 Terraform apply |         "Access-Control-Allow-Headers": [
 2024/09/04 10:37:45 Terraform apply |             "*"
 2024/09/04 10:37:45 Terraform apply |         ],
 2024/09/04 10:37:45 Terraform apply |         "Access-Control-Allow-Methods": [
 2024/09/04 10:37:45 Terraform apply |             "POST, GET, OPTIONS, PUT, DELETE, PATCH"
 2024/09/04 10:37:45 Terraform apply |         ],
 2024/09/04 10:37:45 Terraform apply |         "Access-Control-Allow-Origin": [
 2024/09/04 10:37:45 Terraform apply |             "*"
 2024/09/04 10:37:45 Terraform apply |         ],
 2024/09/04 10:37:45 Terraform apply |         "Cache-Control": [
 2024/09/04 10:37:45 Terraform apply |             "No-Store"
 2024/09/04 10:37:45 Terraform apply |         ],
 2024/09/04 10:37:45 Terraform apply |         "Cf-Cache-Status": [
 2024/09/04 10:37:45 Terraform apply |             "DYNAMIC"
 2024/09/04 10:37:45 Terraform apply |         ],
 2024/09/04 10:37:45 Terraform apply |         "Cf-Ray": [
 2024/09/04 10:37:45 Terraform apply |             "8bdd586d2c3fbbbf-FRA"
 2024/09/04 10:37:45 Terraform apply |         ],
 2024/09/04 10:37:45 Terraform apply |         "Content-Length": [
 2024/09/04 10:37:45 Terraform apply |             "200"
 2024/09/04 10:37:45 Terraform apply |         ],
 2024/09/04 10:37:45 Terraform apply |         "Content-Security-Policy": [
 2024/09/04 10:37:45 Terraform apply |             "script-src * 'unsafe-inline', frame-ancestors 'self'; form-action 'self'"
 2024/09/04 10:37:45 Terraform apply |         ],
 2024/09/04 10:37:45 Terraform apply |         "Content-Type": [
 2024/09/04 10:37:45 Terraform apply |             "application/json"
 2024/09/04 10:37:45 Terraform apply |         ],
 2024/09/04 10:37:45 Terraform apply |         "Date": [
 2024/09/04 10:37:45 Terraform apply |             "Wed, 04 Sep 2024 10:37:39 GMT"
 2024/09/04 10:37:45 Terraform apply |         ],
 2024/09/04 10:37:45 Terraform apply |         "Server": [
 2024/09/04 10:37:45 Terraform apply |             "cloudflare"
 2024/09/04 10:37:45 Terraform apply |         ],
 2024/09/04 10:37:45 Terraform apply |         "Strict-Transport-Security": [
 2024/09/04 10:37:45 Terraform apply |             "max-age=31536000; includeSubDomains"
 2024/09/04 10:37:45 Terraform apply |         ],
 2024/09/04 10:37:45 Terraform apply |         "X-Envoy-Upstream-Service-Time": [
 2024/09/04 10:37:45 Terraform apply |             "371"
 2024/09/04 10:37:45 Terraform apply |         ],
 2024/09/04 10:37:45 Terraform apply |         "X-Request-Id": [
 2024/09/04 10:37:45 Terraform apply |             "70a8869a-68cf-4bb1-be51-1b89e63706d8"
 2024/09/04 10:37:45 Terraform apply |         ]
 2024/09/04 10:37:45 Terraform apply |     },
 2024/09/04 10:37:45 Terraform apply |     "Result": {
 2024/09/04 10:37:45 Terraform apply |         "errors": [
 2024/09/04 10:37:45 Terraform apply |             {
 2024/09/04 10:37:45 Terraform apply |                 "code": "wrong_source_id",
 2024/09/04 10:37:45 Terraform apply |                 "message": "Incorrect source id",
 2024/09/04 10:37:45 Terraform apply |                 "more_info": "https://cloud.ibm.com/apidocs/event-notifications"
 2024/09/04 10:37:45 Terraform apply |             }
 2024/09/04 10:37:45 Terraform apply |         ],
 2024/09/04 10:37:45 Terraform apply |         "status_code": 400,
 2024/09/04 10:37:45 Terraform apply |         "trace": "b5e915e9-8d58-4166-b771-bae57e8d8b0d"
 2024/09/04 10:37:45 Terraform apply |     },
 2024/09/04 10:37:45 Terraform apply |     "RawResult": null
 2024/09/04 10:37:45 Terraform apply | }
 2024/09/04 10:37:45 Terraform apply | 
 2024/09/04 10:37:45 Terraform apply | 
 2024/09/04 10:37:45 Terraform apply |   with ibm_en_topic.en_topic[0],
 2024/09/04 10:37:45 Terraform apply |   on main.tf line 267, in resource "ibm_en_topic" "en_topic":
 2024/09/04 10:37:45 Terraform apply |  267: resource "ibm_en_topic" "en_topic" {

@jor2
Copy link
Member Author

jor2 commented Sep 5, 2024

adding sleep to scc-da terraform-ibm-modules/terraform-ibm-scc-da#184

@jor2
Copy link
Member Author

jor2 commented Sep 5, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Oct 1, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Oct 2, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Oct 2, 2024

/run pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants