feat: add Elasticsearch DA #21
Conversation
akocbek
requested review from
daniel-butler-irl and
rajatagarwal-ibm
as code owners
stack_definition.json
Outdated
| ], | ||
| "outputs": [ | ||
| { | ||
| "name": "es_hostname", |
There was a problem hiding this comment.
es_hostname -> elasticsearch_hostname
stack_definition.json
Outdated
| "value": "ref:./members/7 - Databases for Elasticsearch/outputs/hostname" | ||
| }, | ||
| { | ||
| "name": "es_port", |
stack_definition.json
Outdated
| "value": "ref:./members/7 - Databases for Elasticsearch/outputs/port" | ||
| }, | ||
| { | ||
| "name": "es_certificate_base64", |
There was a problem hiding this comment.
es_certificate_base64 -> elasticsearch_certificate_base64
stack_definition.json
Outdated
| "value": "ref:./members/7 - Databases for Elasticsearch/outputs/certificate_base64" | ||
| }, | ||
| { | ||
| "name": "es_service_credentials_json", |
There was a problem hiding this comment.
es_service_credentials_json -> elasticsearch_service_credentials_json
|
Do we need to explicitly pass a value for |
| } | ||
| } | ||
| ], | ||
| "name": "7 - Databases for Elasticsearch", |
There was a problem hiding this comment.
Should this be renamed "3b - Databases for Elasticsearch" since it has a dependency on 1 - Account Infrastructure Base and 2a - Security Service - Key Management only (and then rename 3a - Security Service - Observability)?
There was a problem hiding this comment.
going with this for now - will revisit later
Description
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers