feat: add support for Secrets Manager Service Credentials #372
+563
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run pipeline |
3 similar comments
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
akocbek
force-pushed
the
sm_credentials
branch
from
8ffaae5 to
31d80a3
Compare
|
/run pipeline |
shemau
requested changes
Feb 24, 2025
solutions/enterprise/DA-types.md
Outdated
| @@ -29,6 +32,73 @@ You can specify a set of IAM credentials to connect to the instance with the `se | |||
| } | |||
| ``` | |||
|
|
|||
| ## Service credential secrets <a name="service-credential-secrets"></a> | |||
|
|
|||
| When you add an IBM Event Notification deployable architecture from the IBM Cloud catalog to IBM Cloud Project, you can configure service credentials. In edit mode for the projects configuration, from the configure panel click the optional tab. | |||
solutions/quickstart/DA-types.md
Outdated
|
|
||
| ## Service credential secrets <a name="service-credential-secrets"></a> | ||
|
|
||
| When you add an IBM Event Notification deployable architecture from the IBM Cloud catalog to IBM Cloud Project, you can configure service credentials. In edit mode for the projects configuration, from the configure panel click the optional tab. |
solutions/enterprise/variables.tf
Outdated
| })) | ||
| default = [] | ||
| nullable = false | ||
| description = "Service credential secrets configuration for Event Notification. [Learn more](https://github.com/terraform-ibm-modules/terraform-ibm-event-streams/tree/main/solutions/enterprise/DA-types.md#service-credential-secrets)." |
solutions/quickstart/variables.tf
Outdated
| })) | ||
| nullable = false | ||
| default = [] | ||
| description = "Service credential secrets configuration for Event Notification. [Learn more](https://github.com/terraform-ibm-modules/terraform-ibm-event-streams/tree/main/solutions/quickstart/DA-types.md#service-credential-secrets)." |
solutions/quickstart/variables.tf
Outdated
| type = bool | ||
| default = false | ||
| nullable = false | ||
| description = "Whether an IAM authorization policy is created for Secrets Manager instance to create a service credential secrets for Event Notification.If set to false, the Secrets Manager instance passed by the user is granted the Key Manager access to the Event Streams instance created by the Deployable Architecture. Set to `true` to use an existing policy. The value of this is ignored if any value for 'existing_secrets_manager_instance_crn' is not passed." |
solutions/enterprise/variables.tf
Outdated
| type = bool | ||
| default = false | ||
| nullable = false | ||
| description = "Whether an IAM authorization policy is created for Secrets Manager instance to create a service credential secrets for Event Notification.If set to false, the Secrets Manager instance passed by the user is granted the Key Manager access to the Event Streams instance created by the Deployable Architecture. Set to `true` to use an existing policy. The value of this is ignored if any value for 'existing_secrets_manager_instance_crn' is not passed." |
akocbek
force-pushed
the
sm_credentials
branch
from
31d80a3 to
348d464
Compare
|
/run pipeline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers