-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iam_token_only parameter #381
base: main
Are you sure you want to change the base?
Conversation
7525aa2
to
d0ef0e3
Compare
/run pipeline |
1 similar comment
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the deployable architecture needs updating, specifically the enterprise variant in solutions/enterprise/. Given the nature of this feature, it might be appropriate to enable it by default in this architecture. This would also give test coverage, otherwise consider changing the test (tests/pr_test.go) to enable it.
Converting to draft. The request to use this in the enterprise variant exposes a test problem. To use the We are looking at a solution (in terraform-provider-ibm) which will create the IAM tokens from the apikey if they are not provided. That will allow the test framework to run with just the (Note, this would not be a problem for customers, as they can generate tokens and set the token environment variables before running terraform. The planned fix will also allow customers to run with only an apikey.) |
/run pipeline |
I'm going to create a new PR to add an upgrade test on the enterprise DA. Once merged, Ill rebase this and then I can see in the test pipeline logs what the exact upgrade behaviour will be for consumers |
PR to add upgrade test #384 |
bc4f763
to
1e1c92f
Compare
/run pipeline |
1 similar comment
/run pipeline |
Description
Event Streams added a provision parameter
iam_token_only
, which when true disables plain SASL authentication and requires IAM token authorization. This adds the parameter to the module.Release required?
x.x.X
)x.X.x
) (minor new feature)X.x.x
)Release notes content
Adds an
iam_token_only
boolean variable which when true disables plain SASL authentication and requires IAM token authorization. This is only allowed for enterprise plans.iam_token_only
defaults totrue
in the Enterprise solution (solutions/enterprise
). Note that this is changes the default authentication method, and requires customers to configure their Kafka clients differently, so is a breaking change. Consumers ofsolutions/enterprise
may want to override the default and setiam_token_only
tofalse
until they are able to make these changes.See the IBM Cloud documentation for using_sasl_oauthbearer for more information.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers