Skip to content

Commit

Permalink
fix: outputs and ci pipeline flag (#49)
Browse files Browse the repository at this point in the history
  • Loading branch information
rajatagarwal-ibm authored Apr 29, 2024
1 parent 8758e3a commit ba43cf2
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 6 deletions.
12 changes: 6 additions & 6 deletions solutions/banking/outputs.tf
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
output "project_id" {
output "watsonx_project_id" {
description = "ID of the created WatsonX project."
value = module.configure_project.project_id
}

output "project_url" {
output "watsonx_project_url" {
description = "WatsonX project ID URL."
value = "https://dataplatform.cloud.ibm.com/projects/${module.configure_project.project_id}"
}

output "watsonx_assistant_url" {
output "watsonx_assistant_api_url" {
description = "WatsonX Assistant URL."
value = local.watsonx_assistant_url
}

output "watsonx_discovery_url" {
output "watsonx_discovery_api_url" {
description = "WatsonX Discovery URL."
value = local.watsonx_discovery_url
}
Expand All @@ -23,12 +23,12 @@ output "cos_instance_crn" {
value = module.cos.cos_instance_crn
}

output "assistant_integration_id" {
output "watsonx_assistant_integration_id" {
description = "WatsonX assistant integration ID."
value = data.external.assistant_get_integration_id.result.assistant_integration_id
}

output "discovery_project_id" {
output "watsonx_discovery_project_id" {
description = "WatsonX Discovery Project ID."
value = data.external.discovery_project_id.result.discovery_project_id
}
5 changes: 5 additions & 0 deletions tests/scripts/pre-validation.sh
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ TF_VARS_FILE="terraform.tfvars"
secrets_manager_guid_var_name="secrets_manager_guid"
secrets_manager_region_var_name="secrets_manager_region"
signing_key_var_name="signing_key"
trigger_ci_pipeline_run_var_name="trigger_ci_pipeline_run"

resource_group_name_value=$(terraform output -state=terraform.tfstate -raw resource_group_name)
toolchain_resource_group_value=$(terraform output -state=terraform.tfstate -raw resource_group_name)
Expand All @@ -58,6 +59,7 @@ TF_VARS_FILE="terraform.tfvars"
create_continuous_delivery_service_instance_value=false
secrets_manager_guid_value=$(terraform output -state=terraform.tfstate -raw secrets_manager_guid)
signing_key_value=$(terraform output -state=terraform.tfstate -raw signing_key)
trigger_ci_pipeline_run_value=false

echo "Appending required input variable values to ${JSON_FILE}.."

Expand Down Expand Up @@ -98,6 +100,8 @@ TF_VARS_FILE="terraform.tfvars"
--arg secrets_manager_guid_value "${secrets_manager_guid_value}" \
--arg signing_key_var_name "${signing_key_var_name}" \
--arg signing_key_value "${signing_key_value}" \
--arg trigger_ci_pipeline_run_var_name "${trigger_ci_pipeline_run_var_name}" \
--arg trigger_ci_pipeline_run_value "${trigger_ci_pipeline_run_value}" \
'. + {($prefix_var_name): $prefix_value,
($resource_group_name_var_name): $resource_group_name_value,
($toolchain_region_var_name): $toolchain_region_value,
Expand All @@ -115,6 +119,7 @@ TF_VARS_FILE="terraform.tfvars"
($watson_machine_learning_instance_resource_name_var_name): $watson_machine_learning_instance_resource_name_value,
($secrets_manager_guid_var_name): $secrets_manager_guid_value,
($secrets_manager_region_var_name): $secrets_manager_region_value,
($trigger_ci_pipeline_run_var_name): $trigger_ci_pipeline_run_value,
($signing_key_var_name): $signing_key_value}' "${JSON_FILE}" > tmpfile && mv tmpfile "${JSON_FILE}" || exit 1

echo "Pre-validation complete successfully"
Expand Down

0 comments on commit ba43cf2

Please sign in to comment.