Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add EoIP tunnel support #283

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

dokmic
Copy link
Contributor

@dokmic dokmic commented Oct 30, 2023

This PR adds Ethernet over IP tunnel support. Most of the properties have been reused, just moved them to the helpers to follow DRY.

The schema has not been changed in 7.x, so it works in both 6.x and 7.x versions.

@dokmic dokmic requested a review from a team as a code owner October 30, 2023 22:52
Copy link
Collaborator

@vaerh vaerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work thanks a lot!

@vaerh vaerh merged commit bcab0fb into terraform-routeros:main Oct 31, 2023
3 checks passed
@vaerh
Copy link
Collaborator

vaerh commented Oct 31, 2023

🎉 This PR is included in version 1.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@vaerh
Copy link
Collaborator

vaerh commented Nov 2, 2023

@dokmic
I want to change the resource key from Name to ID in the next release, because resource names should be avoided in the future due to problems with the provider #192.
Can you test the resource on your data with this change?

		MetaResourcePath: PropResourcePath("/interface/eoip"),
		MetaId:           PropId(Id),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants