Vaerh/issue268 #287
Merged
Vaerh/issue268 #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dokmic
reviewed
Nov 3, 2023
| @@ -9,7 +9,7 @@ import ( | |||
| func ResourceInterfaceEoip() *schema.Resource { | |||
| resSchema := map[string]*schema.Schema{ | |||
| MetaResourcePath: PropResourcePath("/interface/eoip"), | |||
| MetaId: PropId(Name), | |||
| MetaId: PropId(Id), | |||
There was a problem hiding this comment.
@vaerh I tested this particular change. Functionally, that works as expected, but it breaks the existing state. The id property is outdated in the state, and hence terraform loses the link. That can be easily fixed by reimporting the resource, which will update the id property only.
That's kind of a breaking change, but we just released this feature, so I am not sure if that's critical.
There was a problem hiding this comment.
Ok, let's make it pretty. I have added state migration, please test it. Maybe there are some other requests.
For resources with the "Name" identifier
dokmic
approved these changes
Nov 6, 2023
|
🎉 This PR is included in version 1.21.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.