Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix properties validation and some missing properties #337

Merged
merged 5 commits into from
Jan 16, 2024
Merged

fix: Fix properties validation and some missing properties #337

merged 5 commits into from
Jan 16, 2024

Conversation

dokmic
Copy link
Contributor

@dokmic dokmic commented Jan 15, 2024 •
edited
Loading

This PR brings the following:

  • adds the default property in routeros_routing_bgp_template;
  • adds the generated_ca_certificate property in routeros_capsman_manager;
  • adds the generated_certificate property in routeros_capsman_manager;
  • fixes validation of the advertise property in routeros_interface_ethernet (changed in 7.12);
  • fixes validation of the address property in routeros_user_manager_router;
  • adds the port_cost_mode property in routeros_interface_bridge (introduced in 7.13, resolves Missing field in routeros_bridge.bridge #333).

@dokmic dokmic requested a review from a team as a code owner January 15, 2024 23:14
vaerh
vaerh approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@vaerh vaerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@vaerh vaerh merged commit cab4fb6 into terraform-routeros:main Jan 16, 2024
3 checks passed
@vaerh
Copy link
Collaborator

vaerh commented Jan 16, 2024

🎉 This PR is included in version 1.32.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@vaerh vaerh added the released label Jan 16, 2024
@dokmic dokmic deleted the fix/properties branch January 16, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaerh vaerh vaerh approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing field in routeros_bridge.bridge
2 participants
@dokmic @vaerh