Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add http scheme support for the REST API #398

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

dokmic
Copy link
Contributor

@dokmic dokmic commented Mar 26, 2024

This PR enables the http scheme support in the connection settings.

@dokmic dokmic requested a review from a team as a code owner March 26, 2024 21:31
@vaerh
Copy link
Collaborator

vaerh commented Mar 27, 2024

Hi Michael!

Originally this functionality was in the provider but on early versions of ROS it didn't work for some reason.

Please look at the differences between your PR and my implementation. It seems to me that useTLS = false is still needed.

vaerh@a7869fb

Copy link
Collaborator

@vaerh vaerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comment on the PR

@dokmic
Copy link
Contributor Author

dokmic commented Mar 28, 2024

@vaerh I've been exploiting this feature locally for a few weeks already, and so far so good. It works perfectly with a few ROS instances.

The useTLS = false statement is unnecessary, as it only matters when the selected transport is TransportAPI.

@vaerh vaerh merged commit c326052 into terraform-routeros:main Mar 29, 2024
3 checks passed
@vaerh
Copy link
Collaborator

vaerh commented Mar 29, 2024

🎉 This PR is included in version 1.42.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@vaerh vaerh added the released label Mar 29, 2024
@dokmic dokmic deleted the feature/http-support branch April 4, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants