Merge pull request #2244 from alixander/d2oracle-step-bug

d2oracle: exclude edges from writeable object refs
terrastruct · Dec 12, 2024 · 73cfa6c · 73cfa6c
2 parents d9f6320 + a68ab3b
commit 73cfa6c
Show file tree

Hide file tree

Showing 3 changed files with 698 additions and 1 deletion.
diff --git a/d2oracle/edit_test.go b/d2oracle/edit_test.go
@@ -2666,6 +2666,31 @@ scenarios: {
     }
   }
 }
+`,
+		},
+		{
+			name: "step-connection",
+
+			text: `steps: {
+  1: {
+    Modules -- Metricbeat: {
+      style.stroke-width: 1
+    }
+  }
+}
+
+		`,
+			key:       `Metricbeat.style.stroke`,
+			value:     go2.Pointer(`red`),
+			boardPath: []string{"1"},
+			exp: `steps: {
+  1: {
+    Modules -- Metricbeat: {
+      style.stroke-width: 1
+    }
+    Metricbeat.style.stroke: red
+  }
+}
 `,
 		},
 	}

diff --git a/d2oracle/get.go b/d2oracle/get.go
@@ -249,7 +249,7 @@ func GetID(key string) string {
 
 func GetWriteableRefs(obj *d2graph.Object, writeableAST *d2ast.Map) (out []d2graph.Reference) {
 	for i, ref := range obj.References {
-		if ref.ScopeAST == writeableAST && ref.Key.Range.Path == writeableAST.Range.Path {
+		if ref.ScopeAST == writeableAST && ref.Key.Range.Path == writeableAST.Range.Path && len(ref.MapKey.Edges) == 0 {
 			out = append(out, obj.References[i])
 		}
 	}