Merge pull request #2180 from alixander/nested-layer-ref

d2lsp: fix nested board finding
terrastruct · Oct 30, 2024 · b2cf9d3 · b2cf9d3
2 parents c775a9b + 9e60c10
commit b2cf9d3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/d2ir/d2ir.go b/d2ir/d2ir.go
@@ -1838,7 +1838,7 @@ func (m *Map) FindBoardRoot(path []string) *Map {
 				if len(path) == 1 {
 					return f.Map()
 				}
-				return layersf.Map().FindBoardRoot(path[1:])
+				return f.Map().FindBoardRoot(path[1:])
 			}
 		}
 	}
@@ -1849,7 +1849,7 @@ func (m *Map) FindBoardRoot(path []string) *Map {
 				if len(path) == 1 {
 					return f.Map()
 				}
-				return scenariosf.Map().FindBoardRoot(path[1:])
+				return f.Map().FindBoardRoot(path[1:])
 			}
 		}
 	}
@@ -1860,7 +1860,7 @@ func (m *Map) FindBoardRoot(path []string) *Map {
 				if len(path) == 1 {
 					return f.Map()
 				}
-				return stepsf.Map().FindBoardRoot(path[1:])
+				return f.Map().FindBoardRoot(path[1:])
 			}
 		}
 	}

diff --git a/d2lsp/d2lsp_test.go b/d2lsp/d2lsp_test.go
@@ -117,6 +117,12 @@ hi
 layers: {
   x: {
     hello
+
+    layers: {
+      y: {
+        qwer
+      }
+    }
   }
 }
 `,
@@ -130,6 +136,10 @@ layers: {
 	assert.Success(t, err)
 	assert.Equal(t, 0, len(ranges))
 
+	ranges, _, err = d2lsp.GetRefRanges("index.d2", fs, []string{"x", "y"}, "qwer")
+	assert.Success(t, err)
+	assert.Equal(t, 1, len(ranges))
+
 	_, _, err = d2lsp.GetRefRanges("index.d2", fs, []string{"y"}, "hello")
 	assert.Equal(t, `board "[y]" not found`, err.Error())
 }