Merge pull request #2077 from alixander/allow-unfound-board

allow unfound boards
terrastruct · Aug 26, 2024 · b6a9268 · b6a9268
2 parents d507f12 + 1d6adef
commit b6a9268
Show file tree

Hide file tree

Showing 5 changed files with 1,185 additions and 22 deletions.
diff --git a/d2compiler/compile.go b/d2compiler/compile.go
@@ -1205,7 +1205,7 @@ func (c *compiler) validateBoardLinks(g *d2graph.Graph) {
 		}
 
 		if !hasBoard(g.RootBoard(), linkKey.IDA()) {
-			c.errorf(obj.Link.MapKey, "linked board not found")
+			obj.Link = nil
 			continue
 		}
 	}

diff --git a/d2compiler/compile_test.go b/d2compiler/compile_test.go
@@ -2288,7 +2288,9 @@ scenarios: {
 			name: "link-board-not-found",
 			text: `x.link: layers.x
 `,
-			expErr: `d2/testdata/d2compiler/TestCompile/link-board-not-found.d2:1:1: linked board not found`,
+			assertions: func(t *testing.T, g *d2graph.Graph) {
+				tassert.Equal(t, (*d2graph.Scalar)(nil), g.Objects[0].Link)
+			},
 		},
 		{
 			name: "link-board-not-board",
@@ -2299,7 +2301,10 @@ layers: {
     y
   }
 }`,
-			expErr: `d2/testdata/d2compiler/TestCompile/link-board-not-board.d2:2:1: linked board not found`,
+
+			assertions: func(t *testing.T, g *d2graph.Graph) {
+				tassert.Equal(t, (*d2graph.Scalar)(nil), g.Objects[0].Link)
+			},
 		},
 		{
 			name: "link-board-nested",
@@ -2394,7 +2399,9 @@ layers: {
     }
   }
 }`,
-			expErr: `d2/testdata/d2compiler/TestCompile/link-board-underscore-not-found.d2:7:9: linked board not found`,
+			assertions: func(t *testing.T, g *d2graph.Graph) {
+				tassert.Equal(t, (*d2graph.Scalar)(nil), g.Layers[0].Layers[0].Objects[0].Link)
+			},
 		},
 		{
 			name: "import-icon-near",