Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from WSC #92

Closed
terreng opened this issue May 24, 2022 · 11 comments
Closed

Migrate from WSC #92

terreng opened this issue May 24, 2022 · 11 comments
Assignees

Comments

@terreng
Copy link
Owner

terreng commented May 24, 2022

Could you please open a new PR on kzahel/web-server-chrome that does the following:

Please make a separate PR with only these changes, because it will make it much easier for him to merge it.

Once I finish with the initial release, and you create the PR, then we can ask him if he could merge it and do a release on the chrome web store. Sound like a plan?

@ethanaobrien
Copy link
Collaborator

Sounds good. Ill work on this when I get a chance (should be tomorrow but that may change)

@terreng
Copy link
Owner Author

terreng commented May 28, 2022

@ethanaobrien Would be great if you could do this soon. I'm working on the mac app store version (first submission got rejected), and hoping to have the initial release totally done in the next few days...

@ethanaobrien
Copy link
Collaborator

I should be able to do this today. The last time I sat down to do this, I couldn’t figure out the thing with the branches, so I plan to just dust off this other old GitHub account I literally never use and submit the pr there.

@terreng
Copy link
Owner Author

terreng commented May 28, 2022

You should be able to create a new branch on your own fork of the project. You can then submit a pr from that branch, and the pr will be whatever is different between it and the master branch of the original repo. So you should create the new branch based on the original version of the original repo, before any changes you made for another pr.

@ethanaobrien
Copy link
Collaborator

I thought about doing that, but wouldn’t it still merge the 180 commits I have?

@terreng
Copy link
Owner Author

terreng commented May 28, 2022

Not if you create a separate branch based on an earlier commit before your changes.

@ethanaobrien
Copy link
Collaborator

I didn’t know you could do that. Would I just find the last commit made when I cloned it and clone the branch from there?

@ethanaobrien
Copy link
Collaborator

Nevermind. I managed to clone it. Thank you! I didn’t know you could do that

@terreng
Copy link
Owner Author

terreng commented May 28, 2022

On your fork of the repo, you can

  1. View the commit history

Screen Shot 2022-05-28 at 10 53 07 AM

  1. Click the "browse the repository at this point" button the newest commit that wasn't yours

Screen Shot 2022-05-28 at 10 53 25 AM

  1. Make a new branch from that point

Screen Shot 2022-05-28 at 10 53 47 AM

@ethanaobrien
Copy link
Collaborator

@terreng kzahel/web-server-chrome#304

@terreng
Copy link
Owner Author

terreng commented May 30, 2022

Great! Still working on the macOS app store release. Two rejections now. Hopefully I'll work it out soon.

@terreng terreng closed this as completed Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants