-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from WSC #92
Comments
Sounds good. Ill work on this when I get a chance (should be tomorrow but that may change) |
@ethanaobrien Would be great if you could do this soon. I'm working on the mac app store version (first submission got rejected), and hoping to have the initial release totally done in the next few days... |
I should be able to do this today. The last time I sat down to do this, I couldn’t figure out the thing with the branches, so I plan to just dust off this other old GitHub account I literally never use and submit the pr there. |
You should be able to create a new branch on your own fork of the project. You can then submit a pr from that branch, and the pr will be whatever is different between it and the master branch of the original repo. So you should create the new branch based on the original version of the original repo, before any changes you made for another pr. |
I thought about doing that, but wouldn’t it still merge the 180 commits I have? |
Not if you create a separate branch based on an earlier commit before your changes. |
I didn’t know you could do that. Would I just find the last commit made when I cloned it and clone the branch from there? |
Nevermind. I managed to clone it. Thank you! I didn’t know you could do that |
Great! Still working on the macOS app store release. Two rejections now. Hopefully I'll work it out soon. |
Could you please open a new PR on kzahel/web-server-chrome that does the following:
Please make a separate PR with only these changes, because it will make it much easier for him to merge it.
Once I finish with the initial release, and you create the PR, then we can ask him if he could merge it and do a release on the chrome web store. Sound like a plan?
The text was updated successfully, but these errors were encountered: