Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error messages #57

Merged
merged 4 commits into from
Mar 22, 2022
Merged

Fix error messages #57

merged 4 commits into from
Mar 22, 2022

Conversation

ethanaobrien
Copy link
Collaborator

@ethanaobrien ethanaobrien commented Jan 23, 2022

Resolves #55
Closes #59

terreng
terreng previously approved these changes Jan 23, 2022
@ethanaobrien
Copy link
Collaborator Author

@terreng Do you want me to go ahead and add my fix for #55 into this pr?

@terreng
Copy link
Owner

terreng commented Jan 23, 2022

@terreng Do you want me to go ahead and add my fix for #55 into this pr?

Sure

@terreng
Copy link
Owner

terreng commented Jan 27, 2022

@ethanaobrien Want to merge or add a fix for #59 to this pr?

@ethanaobrien
Copy link
Collaborator Author

I'll add a fix for #59 dont merge yet

@terreng terreng mentioned this pull request Feb 6, 2022
16 tasks
@terreng
Copy link
Owner

terreng commented Feb 12, 2022

It might be a good idea to do a little bit more testing on all of the options to catch any remaining bugs before release.

@terreng
Copy link
Owner

terreng commented Feb 15, 2022

@ethanaobrien I'm planning on having the website up soon. I'm not going to add any more features to the app before the initial release. I'm hoping to release soon so we can tell people who use the Web Server for Chrome extension about it. Hopefully we can add a message to the old app with a link, and ask kzahel to push out the update.

Here's what I'm thinking:
"Chrome apps are going away! Web Server for Chrome is now a standalone program: https://simplewebserver.org/"

After initial release, I'll work on adding more features for the next version (v1.2).

Let me know if there's anything else that we should do before release!

@ethanaobrien
Copy link
Collaborator Author

Sorry I havent been able to work much. I kind of already have that. (https://github.com/ethanaobrien/web-server-chrome/blob/master/react-ui/js/index.js#L578) I will just need to change the link.

kzahel/web-server-chrome#264

@terreng
Copy link
Owner

terreng commented Mar 11, 2022

@ethanaobrien Any update on this?

@ethanaobrien
Copy link
Collaborator Author

Sorry, not yet, I should have time to work on this next week

@ethanaobrien
Copy link
Collaborator Author

@terreng Sorry for this taking so long. I've finished

@terreng terreng merged commit 9ac7c35 into terreng:main Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blank page IP changing
2 participants