Add auth header support. #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to authenticate with the gitlab or github API by specifying a `PRIVATE-TOKEN` or `Authorization` header with the http request. Now you can download the ansible source tarball and md5 directly from the gitlab package registry using the gitlab API.
dmeulen
changed the title
dmeulen
changed the title
shk3
approved these changes
Sep 26, 2024
| @@ -87,7 +87,8 @@ func init() { | |||
| pflag.String("http-proto", "https", "Set to 'http' if necessary") | |||
| pflag.String("http-user", "", "HTTP username for pulling the remote file") | |||
| pflag.String("http-pass", "", "HTTP password for pulling the remote file") | |||
|
|
|||
| pflag.String("http-header-name", "", "HTTP header name") | |||
There was a problem hiding this comment.
nit: Let's fill it with context. "HTTP header name for pulling the remote file"
| @@ -87,7 +87,8 @@ func init() { | |||
| pflag.String("http-proto", "https", "Set to 'http' if necessary") | |||
| pflag.String("http-user", "", "HTTP username for pulling the remote file") | |||
| pflag.String("http-pass", "", "HTTP password for pulling the remote file") | |||
|
|
|||
| pflag.String("http-header-name", "", "HTTP header name") | |||
| pflag.String("http-header-value", "", "HTTP header value") | |||
There was a problem hiding this comment.
nit: Let's fill it with context. "HTTP header value for pulling the remote file"
| testEmptyChecksumUrl = "" | ||
| testChecksumUrlPath = "custom.txt.md5" | ||
| testEmptyChecksumUrl = "" | ||
| testChecksumUrlPath = "custom.txt.md5" | ||
|
|
||
| testHashlessFilename = "nohash.txt" | ||
| testHashlessText = []byte("Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.") |
There was a problem hiding this comment.
Can we include the new fields in the test?
|
Will update whein I find some time, rather busy atm! Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to authenticate with the gitlab or github API by specifying a
PRIVATE-TOKENorAuthorizationheader with the http request.Now you can download the ansible source tarball and md5 directly from the gitlab or github package registry using the gitlab API.
example config: