Fix clang-tidy issues 2024-09-12

teslamotors · Sep 13, 2024 · 27a6121 · 27a6121
1 parent 97800b0
commit 27a6121
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 10 deletions.
diff --git a/test/enum_utils_test.cpp b/test/enum_utils_test.cpp
@@ -8,6 +8,7 @@
 #include <gtest/gtest.h>
 
 #include <cstddef>
+#include <functional>
 #include <optional>
 #include <type_traits>
 
@@ -321,27 +322,32 @@ TEST(RichEnum, BoolNegate)
 TEST(RichEnum, StdHash)
 {
     {
-        std::size_t hash_value_of_backing_enum =
+        const std::size_t hash_value_of_backing_enum =
             std::hash<detail::TestRichEnum1BackingEnum>{}(detail::TestRichEnum1BackingEnum::C_ONE);
-        std::size_t hash_value_of_rich_enum = std::hash<TestRichEnum1>{}(TestRichEnum1::C_ONE());
+        const std::size_t hash_value_of_rich_enum =
+            std::hash<TestRichEnum1>{}(TestRichEnum1::C_ONE());
         ASSERT_EQ(hash_value_of_backing_enum, hash_value_of_rich_enum);
     }
     {
-        std::size_t hash_value_of_backing_enum =
+        const std::size_t hash_value_of_backing_enum =
             std::hash<detail::TestRichEnum1BackingEnum>{}(detail::TestRichEnum1BackingEnum::C_TWO);
-        std::size_t hash_value_of_rich_enum = std::hash<TestRichEnum1>{}(TestRichEnum1::C_TWO());
+        const std::size_t hash_value_of_rich_enum =
+            std::hash<TestRichEnum1>{}(TestRichEnum1::C_TWO());
         ASSERT_EQ(hash_value_of_backing_enum, hash_value_of_rich_enum);
     }
     {
-        std::size_t hash_value_of_backing_enum = std::hash<detail::TestRichEnum1BackingEnum>{}(
-            detail::TestRichEnum1BackingEnum::C_THREE);
-        std::size_t hash_value_of_rich_enum = std::hash<TestRichEnum1>{}(TestRichEnum1::C_THREE());
+        const std::size_t hash_value_of_backing_enum =
+            std::hash<detail::TestRichEnum1BackingEnum>{}(
+                detail::TestRichEnum1BackingEnum::C_THREE);
+        const std::size_t hash_value_of_rich_enum =
+            std::hash<TestRichEnum1>{}(TestRichEnum1::C_THREE());
         ASSERT_EQ(hash_value_of_backing_enum, hash_value_of_rich_enum);
     }
     {
-        std::size_t hash_value_of_backing_enum =
+        const std::size_t hash_value_of_backing_enum =
             std::hash<detail::TestRichEnum1BackingEnum>{}(detail::TestRichEnum1BackingEnum::C_FOUR);
-        std::size_t hash_value_of_rich_enum = std::hash<TestRichEnum1>{}(TestRichEnum1::C_FOUR());
+        const std::size_t hash_value_of_rich_enum =
+            std::hash<TestRichEnum1>{}(TestRichEnum1::C_FOUR());
         ASSERT_EQ(hash_value_of_backing_enum, hash_value_of_rich_enum);
     }
 }

diff --git a/test/struct_view_test.cpp b/test/struct_view_test.cpp
@@ -118,7 +118,8 @@ TEST(StructView, ExtractPathPropertiesOfFlat)
 TEST(StructView, StructViewFlat)
 {
     auto super_struct_view = StructView();
-    bool success = super_struct_view.try_add_path<FlatSuperStruct1>(path_from_string("retain1"));
+    const bool success =
+        super_struct_view.try_add_path<FlatSuperStruct1>(path_from_string("retain1"));
     EXPECT_TRUE(success);
 }