Use _GLIBXX_RELEASE instead of __GNUC__ to detect version of libstdc++ #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang defines the __GNUC__,__GNUC_MINOR__, __GNUC_PATCHLEVEL__ macros, but they are hardcoded to version 4.2.1 and do not reflect the real version of libstdc++. Instead, use _GLIBCXX_RELEASE. This allows proper libstdc++ version detection when compiling with clang (and using gcc libs)
alexkaratarakis
force-pushed
the
fix_libstdcpp_detection
branch
from
5dcef03
to
f761e0e
Compare
alexkaratarakis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang defines the GNUC,GNUC_MINOR, GNUC_PATCHLEVEL macros, but they are hardcoded to version 4.2.1 and do not reflect the real version of libstdc++.
Instead, use _GLIBCXX_RELEASE. This allows proper libstdc++ version detection when compiling with clang (and using gcc libs)