Recursive reflection #58
Conversation
alexkaratarakis
force-pushed
the
recursive_reflection
branch
from
6ef3832
to
84e3a5d
Compare
alexkaratarakis
force-pushed
the
recursive_reflection
branch
from
84e3a5d
to
dac260a
Compare
|
|
||
| inline constexpr std::string_view NULL_FIELD_TYPE_NAME{}; | ||
|
|
||
| template <std::size_t MAXIMUM_LAYERS = 32> |
There was a problem hiding this comment.
Should we make it so that this template parameter can be provided by the client? For example, perhaps we can make RecursionType a variant that supports passing in recursion depth if the client wants recursive reflection info.
There was a problem hiding this comment.
Yeah, this was intended to be exposed. Let me consider a nice way to do this, as this type is not meant to be used by the user as it stands.
| } | ||
| [[nodiscard]] constexpr std::string_view current_providing_base_class() const | ||
| { | ||
| return inheritance_stack_.empty() ? NULL_FIELD_TYPE_NAME : inheritance_stack_.top(); |
There was a problem hiding this comment.
Why use a sentinel value instead of just std::optional?
There was a problem hiding this comment.
I went back and forth on this (and also for the same issue for enclosing_field_name() which is empty for the most external layer). Might go for optional.
Also, inconsistency: https://github.com/teslamotors/fixed-containers/pull/58/files#diff-f67f3de59b958f663c7f020e0cdf5d23c952ad56b4abe200caec3c3f60d9ec47R72
The other instance of this uses a hard-coded "".
| { | ||
| using enum reflection_detail::RecursionType; | ||
| auto foo = reflection_detail::field_info_of<RECURSIVE, MyColors>(); | ||
| // std::cout << foo.size() << std::endl; |
There was a problem hiding this comment.
Did you mean to leave this commented-out line here?
There was a problem hiding this comment.
Yeah, this function is for quickly investigating. I had not committed it until know, but after writing it for the n-th time, I left in a small stub in for the future.
No description provided.