Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: booleans on ios and missing prop #690

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: booleans on ios and missing prop #690

wants to merge 1 commit into from
+18 −9

Conversation

WoLewicki
Copy link
Contributor

Summary

PR fixing how booleans are handled on new arch since using the folly converter makes them resolve to true everytime. It also adds missing prop.

@WoLewicki WoLewicki mentioned this pull request Jan 7, 2025
Open
cixio
cixio approved these changes Jan 7, 2025
View reviewed changes
Copy link

@cixio cixio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Thanks!

BrendonGomes
BrendonGomes approved these changes Feb 5, 2025
View reviewed changes
Copy link

@BrendonGomes BrendonGomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution works fine on RN 0.76.5 IOS 18.1 emulator.

stefanep
stefanep approved these changes Feb 5, 2025
View reviewed changes
Copy link

@stefanep stefanep left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function worked smoothly in the android emulator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cixio cixio cixio approved these changes

@BrendonGomes BrendonGomes BrendonGomes approved these changes

@stefanep stefanep stefanep approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WoLewicki @cixio @BrendonGomes @stefanep