Add AzureEventHubsContainer #9665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagyesta
force-pushed
the
feature/add-azure-eventhubs-container
branch
2 times, most recently
from
41ee74d to
4c40dfd
Compare
nagyesta
force-pushed
the
feature/add-azure-eventhubs-container
branch
5 times, most recently
from
148c7fc to
8c821d8
Compare
nagyesta
force-pushed
the
feature/add-azure-eventhubs-container
branch
from
8c821d8 to
fa3e337
Compare
eddumelendez
requested changes
Jan 9, 2025
modules/azure/src/main/java/org/testcontainers/azure/AzureEventhubsEmulatorContainer.java
Outdated
Show resolved
Hide resolved
modules/azure/src/main/java/org/testcontainers/azure/AzureEventhubsEmulatorContainer.java
Outdated
Show resolved
Hide resolved
modules/azure/src/main/java/org/testcontainers/azure/AzureEventhubsEmulatorContainer.java
Outdated
Show resolved
Hide resolved
modules/azure/src/main/java/org/testcontainers/azure/AzureEventhubsEmulatorContainer.java
Outdated
Show resolved
Hide resolved
modules/azure/src/test/java/org/testcontainers/azure/AzureEventhubsEmulatorContainerTest.java
Outdated
Show resolved
Hide resolved
nagyesta
changed the title
nagyesta
commented
Jan 15, 2025
modules/azure/src/main/java/org/testcontainers/azure/AzureEventHubsEmulatorContainer.java
Outdated
Show resolved
Hide resolved
nagyesta
commented
Jan 15, 2025
modules/azure/src/main/java/org/testcontainers/azure/AzureEventHubsEmulatorContainer.java
Outdated
Show resolved
Hide resolved
nagyesta
commented
Jan 16, 2025
modules/azure/src/main/java/org/testcontainers/azure/AzureEventHubsEmulatorContainer.java
Outdated
Show resolved
Hide resolved
nagyesta
force-pushed
the
feature/add-azure-eventhubs-container
branch
from
a35f474 to
490a6c8
Compare
- Add Azure Eventhubs Emulator container - Implement new test case - Update Azure documentation Signed-off-by: Esta Nagy <[email protected]>
- Fix license acceptance - Use Transferable - Remove unnecessary code from tests Signed-off-by: Esta Nagy <[email protected]>
- Fix Typo in the container's name - Require AzuriteContainer as dependency - Add Kafka Event Hubs test - Add Kafka option to Azure documentation Signed-off-by: Esta Nagy <[email protected]>
- Fix typos Signed-off-by: Esta Nagy <[email protected]>
- Fix test method name Signed-off-by: Esta Nagy <[email protected]>
- Polish Signed-off-by: Esta Nagy <[email protected]>
- Simplify config Signed-off-by: Esta Nagy <[email protected]>
- Fix code review findings Signed-off-by: Esta Nagy <[email protected]>
nagyesta
force-pushed
the
feature/add-azure-eventhubs-container
branch
from
490a6c8 to
69d2b6f
Compare
|
Hi @eddumelendez , |
modules/azure/src/main/java/org/testcontainers/azure/AzureEventHubsEmulatorContainer.java
Outdated
Show resolved
Hide resolved
modules/azure/src/main/java/org/testcontainers/azure/AzureEventHubsEmulatorContainer.java
Outdated
Show resolved
Hide resolved
- Rename container - Remove Kafka Signed-off-by: Esta Nagy <[email protected]>
- Rename container in docs Signed-off-by: Esta Nagy <[email protected]>
- Remove automatically added new lines Signed-off-by: Esta Nagy <[email protected]>
eddumelendez
changed the title
|
Thanks for your contribution, @nagyesta ! |
|
Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Must be merged after: #9661
Relates to: #9607 (comment)