Add Valkey module

[mdodsworth]

…ntainer

Adding support for Valkey. Container and tests are based largely on the existing redis setup.

[netlify]

✅ Deploy Preview for testcontainers-node ready!

Name	Link
🔨 Latest commit	840aac3
🔍 Latest deploy log	https://app.netlify.com/sites/testcontainers-node/deploys/67a00636c3b7cb0008f69400
😎 Deploy Preview	https://deploy-preview-906--testcontainers-node.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[cristianrgreco]

I know that this is copied from the Redis container code, but this can be refactored by moving this line into the containerStarted callback (https://node.testcontainers.org/features/containers/#lifecycle-callbacks). Extra ❤️ if you update the Redis container code as well 😄

[mdodsworth]

Will work for ❤️s.
Sure thing, I'll fix them both up

[mdodsworth]

@cristianrgreco changes are ready for review. Thanks fro the input

[cristianrgreco]

Thanks @mdodsworth. I had a thought.

If Valkey is a drop-in replacement for Redis then could we get away with this?

class ValkeyContainer extends RedisContainer {
  constructor(image = "valkey/valkey:8.0") {
    super(image);
  }

  // maybe need to override the start method to return a `StartedValkeyContainer`, 
  // but even this just calls `super(...)` ?
}

EDIT: I think it may complicate things in terms of how the modules depend on each other.

[mdodsworth]

Thanks @mdodsworth. I had a thought.

If Valkey is a drop-in replacement for Redis then could we get away with this?

class ValkeyContainer extends RedisContainer {
  constructor(image = "valkey/valkey:8.0") {
    super(image);
  }

  // maybe need to override the start method to return a `StartedValkeyContainer`, 
  // but even this just calls `super(...)` ?
}

EDIT: I think it may complicate things in terms of how the modules depend on each other.

Yeah, my feeling was that the functionality may eventually diverge, so having it be separate container would be worthwhile