Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecated annotations, bump sbt version #269

Merged

Conversation

greshny
Copy link
Contributor

@greshny greshny commented Jan 25, 2024

  • bump sbt version to 1.9.8
  • fix @deprecated annotations, it should accept two arguments
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/org/testcontainers/containers/TestContainerAccessor.scala:5:2: @deprecated now takes two arguments; see the scaladoc.
[warn] @deprecated("Should be replaced by lifecycle methods")
[warn]  ^
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/MultipleContainers.scala:11:4: @deprecated now takes two arguments; see the scaladoc.
[warn]   @deprecated("Use `stop` instead")
[warn]    ^
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/MultipleContainers.scala:14:4: @deprecated now takes two arguments; see the scaladoc.
[warn]   @deprecated("Use `stop` and/or `TestLifecycleAware.afterTest` instead")
[warn]    ^
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/MultipleContainers.scala:17:4: @deprecated now takes two arguments; see the scaladoc.
[warn]   @deprecated("Use `start` instead")
[warn]    ^
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/MultipleContainers.scala:20:4: @deprecated now takes two arguments; see the scaladoc.
[warn]   @deprecated("Use `stop` and/or `TestLifecycleAware.afterTest` instead")
[warn]    ^
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/MultipleContainers.scala:71:4: @deprecated now takes two arguments; see the scaladoc.
[warn]   @deprecated("Use `stop` instead")
[warn]    ^
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/MultipleContainers.scala:74:4: @deprecated now takes two arguments; see the scaladoc.
[warn]   @deprecated("Use `stop` and/or `TestLifecycleAware.afterTest` instead")
[warn]    ^
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/MultipleContainers.scala:77:4: @deprecated now takes two arguments; see the scaladoc.
[warn]   @deprecated("Use `start` instead")
[warn]    ^
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/MultipleContainers.scala:80:4: @deprecated now takes two arguments; see the scaladoc.
[warn]   @deprecated("Use `stop` and/or `TestLifecycleAware.afterTest` instead")
[warn]    ^
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/DockerComposeContainer.scala:53:4: @deprecated now takes two arguments; see the scaladoc.
[warn]   @deprecated("Please use expanded `apply` method")
[warn]    ^
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/DockerComposeContainer.scala:60:4: @deprecated now takes two arguments; see the scaladoc.
[warn]   @deprecated("Please use expanded `apply` method")
[warn]    ^
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/Container.scala:25:2: @deprecated now takes two arguments; see the scaladoc.
[warn] @deprecated("For internal usage only. Will be deleted.")
[warn]  ^
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/Container.scala:28:4: @deprecated now takes two arguments; see the scaladoc.
[warn]   @deprecated("Please use reflective methods from the wrapper and `configure` method for creation")
[warn]    ^
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/Container.scala:31:4: @deprecated now takes two arguments; see the scaladoc.
[warn]   @deprecated("Use `stop` instead")
[warn]    ^
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/Container.scala:34:4: @deprecated now takes two arguments; see the scaladoc.
[warn]   @deprecated("Use `stop` and/or `TestLifecycleAware.afterTest` instead")
[warn]    ^
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/Container.scala:37:4: @deprecated now takes two arguments; see the scaladoc.
[warn]   @deprecated("Use `start` instead")
[warn]    ^
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/Container.scala:40:4: @deprecated now takes two arguments; see the scaladoc.
[warn]   @deprecated("Use `stop` and/or `TestLifecycleAware.afterTest` instead")
[warn]    ^
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/Container.scala:82:4: @deprecated now takes two arguments; see the scaladoc.
[warn]   @deprecated("See org.testcontainers.containers.Network")
[warn]    ^
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/Container.scala:166:4: @deprecated now takes two arguments; see the scaladoc.
[warn]   @deprecated("Use `stop` instead")
[warn]    ^
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/Container.scala:169:4: @deprecated now takes two arguments; see the scaladoc.
[warn]   @deprecated("Use `stop` and/or `TestLifecycleAware.afterTest` instead")
[warn]    ^
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/Container.scala:172:4: @deprecated now takes two arguments; see the scaladoc.
[warn]   @deprecated("Use `start` instead")
[warn]    ^
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/Container.scala:175:4: @deprecated now takes two arguments; see the scaladoc.
[warn]   @deprecated("Use `stop` and/or `TestLifecycleAware.afterTest` instead")
[warn]    ^
[warn] /Users/roman/git/github.com/testcontainers-scala/core/src/main/scala/com/dimafeng/testcontainers/implicits/DockerImageNameConverters.scala:6:4: @deprecated now takes two arguments; see the scaladoc.
[warn]   @deprecated("Use `DockerImageName` in Container constructor instead")
[warn]  

[warn] /Users/roman/git/github.com/testcontainers-scala/modules/vault/src/main/scala/com/dimafeng/testcontainers/VaultContainer.scala:8:23: @deprecated now takes two arguments; see the scaladoc.
[warn]                      @deprecated vaultPort: Option[Int] = None,
[warn]                       ^
[warn] /Users/roman/git/github.com/testcontainers-scala/modules/vault/src/main/scala/com/dimafeng/testcontainers/VaultContainer.scala:40:14: @deprecated now takes two arguments; see the scaladoc.
[warn]             @deprecated vaultPort: Option[Int] = None,
[warn]              ^
[warn] /Users/roman/git/github.com/testcontainers-scala/modules/vault/src/main/scala/com/dimafeng/testcontainers/VaultContainer.scala:51:6: @deprecated now takes two arguments; see the scaladoc.
[warn]     @deprecated vaultPort: Option[Int] = None,
[warn]      ^

@greshny greshny changed the title fix @deprecated annotations, bump sbt version fix deprecated annotations, bump sbt version Jan 25, 2024
@dimafeng dimafeng merged commit 1176c30 into testcontainers:master Jan 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants