ci/dev: Windows support #80
Conversation
|
.gitattributes was two lines for some reason (created with echo command). Corrected but it still fails. Cloned a fresh copy and had the same issue. I had saved files locally in my working clone with lf but assumed attributes would look after things. Researching. Update: The doc indicates git checks for .gitattributes in the working tree and the index. Speculating that until the commit is part of the main branch the file will not be seen and enforced. I can open a separate PR or you (@searls) could pull it into your main and push it in. Cloning a local repo of teenytest gets the proper eol values. Let me know how you want to proceed. |
WIndows has issues running bash scripts with crlf. Signed-off-by: Chris. Webster <[email protected]>
git may not create links for the test file. Other test files are not links so maybe this does not need to be one either. Signed-off-by: Chris. Webster <[email protected]>
git does not always create links so using relative paths expands on WIndows compatability. Signed-off-by: Chris. Webster <[email protected]>
Running on Windows needs the command to be specified in `package.json`. Signed-off-by: Chris. Webster <[email protected]>
Remove some shebang assumptions. Added test:safe:esm which runs some tests for Windows in the cmd shell. test:safe:bats tests run under bash so they do not test WIndows pathname issues. Signed-off-by: Chris. Webster <[email protected]>
|
Merged! I'll take your word for it @webstech. Appreciate your patience in my responses, and I am so grateful for your persistence in this |
|
It looks like this still failed on Windows after hitting main |
This patch series provides support for running development and the CI on Windows. It includes changes listed in issue #26 (and includes some that were missed).
ci: force linends to lf on all platforms
Windows has issues running bash scripts with crlf.
maint: replace link with actual file
git may not create links for the test file. Other test files are not links so maybe this does not need to be one either.
maint: change links to relative paths
git does not always create links so using relative paths expands on WIndows compatability.
ci: do not rely on shebang support
Running on Windows needs the command to be specified in
package.json.ci: windows support and windows specific test
Remove some shebang assumptions.
Added test:safe:esm which runs some tests for Windows in the cmd shell. test:safe:bats tests run under bash so they do not test WIndows pathname issues. This is the test mentioned in pr fix: use file URL for esm import and remove node version check #75.
Tested on Windows cmd and wsl.
No offence if some of the patches are not accepted (or none) or need changes. This provides a record for the future. If the changes are accepted, there may be some link cleanup to be done.