fix: resolve conversation

testing-library · Mar 17, 2024 · 9137931 · 9137931
1 parent 000b3e8
commit 9137931
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 26 deletions.
diff --git a/src/__tests__/render.js b/src/__tests__/render.js
@@ -89,31 +89,14 @@ test('unmounts', () => {
   expect(queryByTestId('node')).not.toBeInTheDocument()
 })
 
-test('use unmount before cleanup', () => {
-  const TestComponent = defineComponent((_, {slots}) => {
-    return () => slots.default?.()
-  })
+test('unmounts when no wrapper element is present', () => {
+  const Comp = defineComponent((_, ctx) => () => ctx.slots.default?.())
 
-  const {getByTestId, unmount, queryByTestId} = render({
-    render() {
-      return h(
-        TestComponent,
-        {},
-        {
-          default: () =>
-            h('div', {
-              'data-testid': 'node',
-            }),
-        },
-      )
-    },
+  const {unmount} = render({
+    render: () => h(Comp, () => h('div')),
   })
 
-  expect(getByTestId('node')).toBeInTheDocument()
-
   unmount()
 
-  expect(queryByTestId('node')).not.toBeInTheDocument()
-
   expect(() => cleanup()).not.toThrow()
 })
diff --git a/src/render.js b/src/render.js
@@ -60,11 +60,7 @@ function cleanup() {
 }
 
 function cleanupAtWrapper(wrapper) {
-  if (
-    wrapper.element &&
-    wrapper.element.parentNode &&
-    wrapper.element.parentNode.parentNode === document.body
-  ) {
+  if (wrapper.element?.parentNode?.parentNode === document.body) {
     document.body.removeChild(wrapper.element.parentNode)
   }