Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update design.rst #237

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Cryptinterested
Copy link

I changed block time to 30 seconds since Granada is now live

I changed block time to 30 seconds since Granada is now live
@utdemir
Copy link
Contributor

utdemir commented Aug 16, 2021

Thanks.

This makes me wonder if any of our default constants should also change, specifically: max_bid_interval_in_blocks.

Previously that max_bid_interval_in_blocks and max_bid_interval_in_seconds were aligned (eg. they would take approximately the same time). To keep the same ratio, it might make sense to double the max_bid_interval_in_blocks. What do you think @gkaracha?

@gkaracha
Copy link
Contributor

This makes me wonder if any of our default constants should also change, specifically: max_bid_interval_in_blocks.

Previously that max_bid_interval_in_blocks and max_bid_interval_in_seconds were aligned (eg. they would take approximately the same time). To keep the same ratio, it might make sense to double the max_bid_interval_in_blocks. What do you think @gkaracha?

Ah, yes, great point @utdemir 👌 I certainly agree on keeping the ratio, but I wonder if to achieve that we should half max_bid_interval_in_seconds or double max_bid_interval_in_blocks. Either option would make sense to me, but the first is more fast-paced than the second (time-wise). This also makes me think about the descending auction price which is also a function of time. If everything happens faster regarding the bids, we might want to make the minimum bid descend a little faster as well, otherwise the first bid might take many blocks to appear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants