Adding unit tests, mutation tests, other tests #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murbard
reviewed
Sep 21, 2021
tests/unit_test.mligo
Outdated
| @@ -0,0 +1,98 @@ | |||
| (* This is a unit testing framework for ctez *) | |||
There was a problem hiding this comment.
what is the different between test.mligo and unit_test.mligo? Please indicate in file comments
There was a problem hiding this comment.
Just pushed a commit that:
- Adds comments at the head of each file explaining exactly what is tested and how
- Adds the
.pyfile that generates the data and expected values - Updates the
test_paramsfile with the parameters generated by the.pyfile
… This necesstiated changing test_params for reproducibility.
|
Have just found some bugs in |
…nd the special cases induced by the unit tests themselves.
…out the commands in the main function. This is a ligo bug that should hopefully be fixed soon. Tests on the drift functionality will come after some ligo bug fixes.
|
The tests here should run and pass with the current codebase, with the following caveats:
In case the comments in
|
murbard
reviewed
Sep 27, 2021
tests/generate_test_params.py
Outdated
| x = random.randint(0,100000000000000) # between 0 and 100_000_000 XTZ | ||
| y = random.randint(0,100000000000000) # between 0 and 100_000_000 CTEZ | ||
| dx = random.randint(0, min(x,y)) # so as to not exceed the supply | ||
| target = random.randint(0, 28147497671065600) # betweeen 0 and 100 |
There was a problem hiding this comment.
100 * 2**48 is more readable
There was a problem hiding this comment.
Good call. Changed and pushed.
murbard
reviewed
Sep 27, 2021
| # Generate the following vector: | ||
| # (x, y, dx, target, rounds, const_fee) | ||
| for i in range(n): | ||
| x = random.randint(0,100000000000000) # between 0 and 100_000_000 XTZ |
There was a problem hiding this comment.
10**8
Do you mutez though?
There was a problem hiding this comment.
Yes, the parameter x varies between 0 and 100_000_000_000_000 mutez, or 100_000_000 tez (did I understand your question right?)
murbard
reviewed
Sep 27, 2021
tests/generate_test_params.py
Outdated
| for i in range(len(rand_data)): | ||
| if switch: | ||
| (x,y,dy,a,rounds,const_fee) = rand_data[i] | ||
| b = 281474976710656 |
There was a problem hiding this comment.
Good call. Changed and pushed.
couillardcharles
pushed a commit
to bender-labs/ctez
that referenced
this pull request
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These add unit tests and mutation tests (both in the
unit_tests.mligo).See comments on the mutation tests for how the output should be interpreted.
A current bug in Ligo is giving problems for
test.mligo.