Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix print time metrics not being cleared correctly #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix print time metrics not being cleared correctly #41

wants to merge 2 commits into from

Conversation

hyperair
Copy link
Contributor

@hyperair hyperair commented Feb 5, 2024

This fixes an issue where print time metrics for a path that has completed don't get fully cleared after print completion

@hyperair hyperair mentioned this pull request Feb 5, 2024
Open
@tg44 tg44 mentioned this pull request Feb 5, 2024
Open
@arcnmx
Copy link

arcnmx commented Jul 14, 2024

Trying this seemed to result in an error after a cancel?

Exception in thread Thread-102:
TypeError: PrometheusExporterPlugin.print_deregister_callback() takes 2 positional arguments but 51 were given
Exception in thread Thread-106:
TypeError: PrometheusExporterPlugin.print_deregister_callback() missing 1 required positional argument: 'label'

@hyperair
Fix args passing to Timer
3b7e0a8 
Timer takes args as a single parameter, not *args
@hyperair
Copy link
Contributor Author

Oops, just fixed that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyperair @arcnmx