Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding proxy environment variable support #1907

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flipdazed
Copy link

allows tunneling

set HTTP_PROXY and HTTPS_PROXY to utilise

conn = conFn(proxy_host, proxy_port)
conn.set_tunnel(host, port)
else:
conn = httplib.HTTPSConnection(host, port)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about if no proxy env variables are set, but the port is also not 443. In this implementation it seems to still use HTTPSConnection anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants