Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create socket in YowNetworkLayer with socket.create_connection #2423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create socket in YowNetworkLayer with socket.create_connection #2423

wants to merge 1 commit into from

Conversation

chomechome
Copy link

Came across a problem with yowsup in an IPv6 network. Currently, AF_INET socket is always created during connection to WhatsApp endpoints, and it fails to connect to non-IPv4 addresses. However, socket module has a convenience function create_connection that creates and connects a socket to a given address. It handles detection of address family and socket type itself, thus creating a suitable socket both in IPv4 and IPv6 environments.

@wronglink
Copy link

Following this PR as I have troubles with IPv6-only environment. The current workaround solves it.

@tgalal tgalal added this to the Next milestone May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants