Thermo-Bluespace Generator (groundside gens rework) #16889
Conversation
tgstation-server
added
Sprites
|
Awesome pr, would definitely like to see it tested I am concerned about the maps with disks directly next to the generator such as ice colony, LV624, lawanka, research outpost, gelida, icy caves, and riptide. I think the opportunity cost is too low to justify including it in these spots and in some cases on these maps in general. Smaller maps like the crash ones may also be too small to justify these, as if marines are ahead it'll likely turn into a very fast win using these. Overall I am very excited to see new map objectives though I do not believe they will fit into every one of our maps. Keep up the good work! |
|
Would be nice if this works but not sure marines will bother to split up for it yet, not with how things are balanced lmfao. |
|
will it have a health bar like a turret or will it need a windup like a miner ,also will it be susceptible to chem clouds like sents and boiler. Because if a sentinel just lobs a nade or boiler rng misses the cades and nails the reactor and that makes it go boom it will be pretty dangerous for marines to bother. |
Windup like miner & isn't affected by clouds
Agreed but I'd like to try it out anyway |
|
hey shouldn't you make it so if a xenos is damaged while breaking the gen the cast is broken like with drains |
|
Its been a while since someone thought about something for engineers to do other than miners |
Please no, that would mean it's only possible to destroy when xenos have already won |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
github-actions
bot
added
the
Stale
TiviPlus
removed
the
Stale
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
github-actions
bot
added
the
Stale
TiviPlus
removed
the
Stale
| /// List of active generators groundside | ||
| var/generators_on_ground | ||
| /// List of active TBG generators; used for disks | ||
| var/active_bluespace_generators | ||
| /// List of lights for the TBG generator | ||
| var/generator_alarm_lights = list() |
There was a problem hiding this comment.
Why are these vars here and not a glob /on the generator itself
| ///How much faster disk generators get while the colony power speed boost is active | ||
| var/overclock_multiplier = 3.0 |
There was a problem hiding this comment.
shouldnt this be a define? also dont use decimals if you dont need em
| if(current_timer) | ||
| deltimer(current_timer) | ||
| var/seconds_remaining = (seconds_elapsed SECONDS) - (segment_time*completed_segments) | ||
| current_timer = addtimer(CALLBACK(src, PROC_REF(complete_segment)), (segment_time-seconds_remaining)/overclock_multiplier, TIMER_STOPPABLE) |
There was a problem hiding this comment.
Couldnt you also use timeleft instead of this math? Any particular reason you did it this way?
|
|
||
| ///Stops the overclock boost; called when xenos take down colony power again | ||
| /obj/machinery/computer/nuke_disk_generator/proc/stop_power_overclocking() |
There was a problem hiding this comment.
couldnt you merge these two procs and just make it a toggle instead?
| balloon_alert_to_viewers("[src] begins to whirr as it powers up.") | ||
| if(50) | ||
| balloon_alert_to_viewers("[src] begins to hum loudly as it reaches half capacity.") | ||
| if(100) | ||
| balloon_alert_to_viewers("[src] rumbles loudly as the combustion and thermal chambers reach full strength.") |
There was a problem hiding this comment.
dont use name inserts in baloon alerts: players see its above the generator they can see whats doing it
| COOLDOWN_START(src, toggle_power, 10 SECONDS) | ||
| ambient_soundloop.start() | ||
| SSmachines.active_bluespace_generators++ | ||
| SEND_SIGNAL(SSmachines, COMSIG_GLOB_BLUESPACE_GEN_ACTIVATED) |
There was a problem hiding this comment.
we have global signals fyi - see SEND_GLOBAL_SIGNAL
| if(!..()) | ||
| return FALSE |
There was a problem hiding this comment.
its safer if theres a runtime and it means less boilerplate changes when the code is chaged later
| //Time until explosion -- Devastate range -- Heavy range -- Light range -- Fire range | ||
| var/list/list_of_explosions = list( | ||
| list(0, 5, 10, 2, 40 SECONDS), | ||
| list(0, 10, 15, 7, 43 SECONDS), | ||
| list(0, 10, 17, 7, 45 SECONDS), | ||
| list(0, 15, 20, 15, 46 SECONDS), | ||
| list(0, 15, 20, 15, 47 SECONDS), | ||
| list(0, 15, 20, 15, 49 SECONDS), | ||
| list(0, 15, 20, 15, 50 SECONDS), | ||
| list(0, 15, 20, 15, 52 SECONDS) | ||
| ) |
| . += image(icon, src, "circ_overlay_corrupted", layer) | ||
|
|
||
| // Forward all repair/xeno attack actions to the central TBG engine | ||
| /obj/machinery/power/tbg_turbine/welder_act/(mob/living/user, obj/item/I) |
There was a problem hiding this comment.
| /obj/machinery/power/tbg_turbine/welder_act/(mob/living/user, obj/item/I) | |
| /obj/machinery/power/tbg_turbine/welder_act(mob/living/user, obj/item/I) |
| /obj/machinery/power/geothermal/tbg/proc/trigger_alarms() | ||
| alarm_soundloop.start() | ||
| //Trigger alarm lights | ||
| for(var/obj/machinery/floor_warn_light/toggleable/generator/light in SSmachines.generator_alarm_lights) |
There was a problem hiding this comment.
fyi you can use
for(x AS in y)
to make it skip type checks in these lists
About The Pull Request
[TM because walance
+ I did all of the mapping at 2am and need to double check it all]Adds the thermo-bluespace generator to all groundside maps. (Some regular geothermal gens still exist.)
The bluespace gen is a powerful but volatile generation method used on the colonies of the outer rim. Its bluespace fuel source is easy to deliver and incredibly efficient.
Intention is to make gens a secondary objective which gives an actual goal for multiple squads (i.e one on disks; one on gens).
Video example of meltdown because github won't let me embed: https://cdn.discordapp.com/attachments/500801682058379265/1326905126555881502/generator.mp4?ex=67812032&is=677fceb2&hm=de6aa5e49a27694f43f774d1a055eaf9696c5c767f111d6749abbd77ab92d0e3&
Why It's Good For The Game
Currently all we have for non-disk objectives is req-oriented stuff which 1) is incredibly obtuse to operate and 2) relies on the RO being both competent and present (lol).
This provides a high-risk high-reward secondary objective which should lead to more actual plans (e.g secure gens so that caves disk can be speedran) with still some counterplay for xenos (if they hit gens they get to wipe out that squad pretty easily thanks to explosion forcing them to move)
While I am wary of adding a "sit and wait for xenos to come to you" objective, I think that this one gets a pass for a few reasons:
Changelog
🆑
add: Thermo-Bluespace Generator. Triples disk speed while active; explodes when destroyed by xenos.
imageadd: tbg.dmi
soundadd: tbg_windup, tbg_winddown, tbg_mid1, tbg_mid2, tbg_mid3, tbg_mid4, tbg_mid5, tbg_alarm
/:cl: