Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped ecma version on eslint #1019

Merged
merged 10 commits into from
Oct 28, 2023
Merged

Bumped ecma version on eslint #1019

merged 10 commits into from
Oct 28, 2023

Conversation

gsriram24
Copy link
Contributor

@gsriram24 gsriram24 commented Oct 15, 2023

Related issue

Closes #1010

Context / Background

The issue of ESLint throwing an error with the nullish coalescing operator has been resolved by bumping up the ecmaVersion to 2020.

What change is being introduced by this PR?

The ecmaVersion in the .eslintrc.json has been changed to 2020 instead of 2018.

How will this be tested?

Run npm run lint to check if the issue persists.

Copy link
Collaborator

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gsriram24! Can you please revert all the formatting changes and keep only the bump up to 2020, please?

@gsriram24
Copy link
Contributor Author

Thanks @gsriram24! Can you please revert all the formatting changes and keep only the bump up to 2020, please?

Could you please check now?

@araujoarthur0
Copy link
Collaborator

@gsriram24 there are still two unrelated changes when looking at the files changed tab here.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #1019 (97cc4ca) into main (e25523f) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1019   +/-   ##
=======================================
  Coverage   75.04%   75.04%           
=======================================
  Files          26       26           
  Lines        2188     2188           
  Branches      345      345           
=======================================
  Hits         1642     1642           
  Misses        546      546           

@gsriram24
Copy link
Contributor Author

@gsriram24 there are still two unrelated changes when looking at the files changed tab here.

The change in changelog.md is made by npm run lint-fix. I cannot commit without making that change as the precommit hook fails.

@tupaschoal
Copy link
Collaborator

@gsriram24 there are still two unrelated changes when looking at the files changed tab here.

The change in changelog.md is made by npm run lint-fix. I cannot commit without making that change as the precommit hook fails.

There's a way to workaround it, but nvm

changelog.md Outdated Show resolved Hide resolved
@BamButz
Copy link
Contributor

BamButz commented Oct 25, 2023

Is there anything left, that blocks this PR from getting merged?
It seems to be corrected and ready to merge from my sight.

@gsriram24
Copy link
Contributor Author

Is there anything left, that blocks this PR from getting merged? It seems to be corrected and ready to merge from my sight.

I think we can get it merged, nothing is left.

@araujoarthur0 araujoarthur0 merged commit 96a524e into thamara:main Oct 28, 2023
9 checks passed
@araujoarthur0
Copy link
Collaborator

\changelog-update

@gsriram24 gsriram24 deleted the Issue1010-ESLint branch October 29, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

es-lint is failing to recognize ?? operator in workday-waiver.js
4 participants