-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped ecma version on eslint #1019
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gsriram24! Can you please revert all the formatting changes and keep only the bump up to 2020, please?
Could you please check now? |
@gsriram24 there are still two unrelated changes when looking at the files changed tab here. |
Codecov Report
@@ Coverage Diff @@
## main #1019 +/- ##
=======================================
Coverage 75.04% 75.04%
=======================================
Files 26 26
Lines 2188 2188
Branches 345 345
=======================================
Hits 1642 1642
Misses 546 546 |
The change in changelog.md is made by |
There's a way to workaround it, but nvm |
Is there anything left, that blocks this PR from getting merged? |
I think we can get it merged, nothing is left. |
\changelog-update |
Related issue
Closes #1010
Context / Background
The issue of ESLint throwing an error with the nullish coalescing operator has been resolved by bumping up the ecmaVersion to 2020.
What change is being introduced by this PR?
The ecmaVersion in the
.eslintrc.json
has been changed to 2020 instead of 2018.How will this be tested?
Run
npm run lint
to check if the issue persists.