Switching most expect calls to node assert #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1057 +/- ##
=======================================
Coverage 80.00% 80.00%
=======================================
Files 20 20
Lines 1270 1270
Branches 191 191
=======================================
Hits 1016 1016
Misses 254 254 ☔ View full report in Codecov by Sentry. |
tupaschoal
reviewed
Jan 26, 2024
tupaschoal
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Helps #1037
Context / Background
As described in #1054, jest no longer works with electron and we'll be switching to mocha. Mocha does not have its own assertion library, so we'll be using node's "assert" library.
What change is being introduced by this PR?
Replacing all possible "expect" calls from jest with the correspondent ones from "assert", so the changes in the next PR are smaller.
How will this be tested?
Tests are passing in the same way.