Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preference window alignment issue fixed #380

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Conversation

akaash11
Copy link
Contributor

@akaash11 akaash11 commented Oct 1, 2020

Related issue

Closes #

Context / Background

What change is being introduced by this PR?

How will this be tested?

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #380 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #380   +/-   ##
=======================================
  Coverage   57.86%   57.86%           
=======================================
  Files          23       23           
  Lines        2046     2046           
  Branches      344      344           
=======================================
  Hits         1184     1184           
  Misses        762      762           
  Partials      100      100           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a41e44d...1e41a5f. Read the comment docs.

@thamara
Copy link
Owner

thamara commented Oct 1, 2020

@akaash11 Can you please provide screenshots of the before/after?

css/styles.css Show resolved Hide resolved
@araujoarthur0
Copy link
Collaborator

I'm not seeing an improvement here, nor was there an issue open for this.
What was the reasoning behind this PR, @akaash11?

You usually need to open a valid issue and then request assignment before you submit PRs, as @thamara explained here #392.

@akaash11
Copy link
Contributor Author

akaash11 commented Oct 5, 2020

Hi @araujoarthur0 , issue was raised by @thamara "Preferences window is too small for its content #362 " that's the reason behind this pull request. Text alignment of "Overall balance start date" was wrong as compared to others in the User preference window for small window size.

@thamara
Copy link
Owner

thamara commented Oct 5, 2020

This doesn't really solve the problem, but still is a valid change, so I think we are ok on merging it.

@thamara
Copy link
Owner

thamara commented Oct 5, 2020

\changelog-update
User: akaash11

@thamara thamara merged commit 21823e8 into thamara:main Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants