Improve notifications - coverage tests #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/ochan12/time-to-leave into improve-notifications-coverage-tests
|
Hey @tupaschoal this is going to be impossible to review. Are you okay with me splitting this into smaller pieces? |
|
Yes, please do, it will be easier for all :) |
|
@ochan12 are you willing to continue this PR? You had split it up to another smaller one, not sure how much is left here. |
|
@tupaschoal Yes, I'll update it |
ochan12
force-pushed
the
improve-notifications-coverage-tests
branch
from
449840b
to
2e597c6
Compare
ochan12
force-pushed
the
improve-notifications-coverage-tests
branch
from
2e597c6
to
8c63f4c
Compare
|
It is ready now @tupaschoal |
tupaschoal
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Great job, here's the summary of coverage change after your PR:
time-to-leave/js 73.13 -> 73.99
main-window.js 67.36 -> 67.70
menus.js 79.06 -> 78.82
time-balance.js 97.56 -> 100.0
time-math.js 78.72 -> 100.0
update-manager.js 00.00 -> 42.85
windows.js 26.92 -> 93.54
time-to-leave/src 78.83 -> 79.52
workday-waiver.js 76.65 -> 77.53
We got some to 100% and a huge increase on some others, which is great!
|
\changelog-update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Coverage test #906
Context / Background
These were changes I made trying to hit the coverage target, but were completely unrelated to #906 issues. So in order to keep the changes smaller and more focused I created this new PR with tests.
What change is being introduced by this PR?
resetWindows()to execute on testsHow will this be tested?
With Jest automates test suites